Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to write and run tests #373

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Document how to write and run tests #373

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2897fc0
Create Testing.md
caspervonb Jan 14, 2021
77dc00b
Add note about wasm32-unknown-unknown
caspervonb Jan 15, 2021
bb3e04b
gqq
caspervonb Jan 15, 2021
5a9e3f4
Quote instead of escape
caspervonb Jan 15, 2021
2686e48
Given an <input.wasm> file
caspervonb Jan 15, 2021
73ae0ef
Update docs/Testing.md
caspervonb Jan 15, 2021
76e1d40
Add $env to the example runner
caspervonb Jan 16, 2021
6d24e22
Minor fixes
caspervonb Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/Testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ be present:
To run a test do the following steps to prepare for execution:

- Prepare inputs
- Given an `<input>` module; take the <basename> of said module.
- Given an `<input>.wasm` file; take the `<basename>` of said module.
caspervonb marked this conversation as resolved.
Show resolved Hide resolved
- If `<basename>.<arg>` exists; take the program arguments from said file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a minor detail, but I'd find this more clear with ".args" instead of ".arg".

Also, we should document the whitespacing convention in the arguments file. Can we say that arguments are separated by whitespace, and '"' quotes may be used to enclose an argument containing whitespace?

- If `<basename>.<env>` exists; take the program environment from said file.
- If `<basename>.<dir>` exists; preopen the directory from said file.
Expand Down