Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the JavaScript Exception tag and allow importing it #269

Merged
merged 31 commits into from
Apr 26, 2024
Merged

Expose the JavaScript Exception tag and allow importing it #269

merged 31 commits into from
Apr 26, 2024

Commits on Mar 16, 2023

  1. Add exceptional return to func_invoke in embedding doc 

    This is a basic start of what we'll need to add to the embedder spec.
I'm not sure if we also need a way to allow exceptions to bubble
from the embedder into wasm ; I don't see any reference to what
happens when the instance wants to call an import, so maybe not.
Also the references aren't quite right, but I may need help
to fix that
    @dschuff
    dschuff committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    587dafb View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. review comments

    @dschuff
    dschuff committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    15a47cf View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. swap order of error/exception in func_invoke

    @dschuff
    dschuff committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    904a8fb View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Expose the JavaScript Exception tag and allow importing it

    @dschuff
    dschuff committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    fe0d00e View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. review suggestions

    @dschuff
    dschuff committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ec302e1 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Andreas Rossberg <[email protected]>
    @dschuff @rossberg
    dschuff and rossberg committed May 4, 2023
    Configuration menu
    Copy the full SHA
    fdf1b7c View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. fix typo

    @dschuff
    dschuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    997754d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into js-tag-import

    @dschuff
    dschuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a276636 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into embedding-invoke

    @dschuff
    dschuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4799452 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. add exception allocation

    @dschuff
    dschuff committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    f57cdb8 View commit details
    Browse the repository at this point in the history

  2. udpate for exnref

    @dschuff
    dschuff committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    ccbee0f View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. apply all suggestions other than exn_read

    @dschuff
    dschuff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    4d08a58 View commit details
    Browse the repository at this point in the history

  2. add exn_read

    @dschuff
    dschuff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    74a92cb View commit details
    Browse the repository at this point in the history

  3. Update allocation, initialization, construction and call-exported-fn

    @dschuff
    dschuff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b17459a View commit details
    Browse the repository at this point in the history

  4. fix linkage, syntax

    @dschuff
    dschuff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    fa07dea View commit details
    Browse the repository at this point in the history

  5. fix typo

    @dschuff
    dschuff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ea5217b View commit details
    Browse the repository at this point in the history

  6. fix vars

    @dschuff
    dschuff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    1c958c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge branch 'main' into exnref-js

    @dschuff
    dschuff committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    46de060 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. address comments

    @dschuff
    dschuff committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5b8380a View commit details
    Browse the repository at this point in the history

  2. remove Tag parameter from getArg

    @dschuff
    dschuff committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    4d03423 View commit details
    Browse the repository at this point in the history

  3. remove 2 more spurious references to webassembly throw

    @dschuff
    dschuff committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d073cfe View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. more properly allocate the JS exception tag, and wrap/unwrap JS excep… 

    …tions.

Wasm throwing is still not properly defined.
    @dschuff
    dschuff committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    b6a79f9 View commit details
    Browse the repository at this point in the history

  2. apply review comments

    @dschuff
    dschuff committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    51338d7 View commit details
    Browse the repository at this point in the history

  3. inline throwing into 'create a host function' and define in terms of … 

    …throw_ref
    @dschuff
    dschuff committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    dfdd0b9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'exnref-js' into js-tag-import

    @dschuff
    dschuff committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a80e7b3 View commit details
    Browse the repository at this point in the history

  5. update for exnref

    @dschuff
    dschuff committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    bc04bb4 View commit details
    Browse the repository at this point in the history

  6. remove leftover text

    @dschuff
    dschuff committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    6c05eaa View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. revert algorithm change

    @dschuff
    dschuff committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    bece351 View commit details
    Browse the repository at this point in the history

  2. add getter

    @dschuff
    dschuff committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    41b08cf View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Merge branch 'main' into js-tag-import

    @dschuff
    dschuff committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d3c3ab6 View commit details
    Browse the repository at this point in the history

  2. Don't allow construction of a WebAssembly.Exception object with the J… 

    …S Tag
    @dschuff
    dschuff committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8834860 View commit details
    Browse the repository at this point in the history