Revive legacy JS API and restructure legacy spec directory #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renames `document/legacy/exceptions` to `document/legacy/exception-handling` to match the proposal name. - This adds `core` and `js-api` directory in `document/legacy/exception-handling`, moves all core spec files into `core/`, and restores the deleted legacy JS API files in `js-api/`. The core legacy spec only contains the EH instructions, which is easier to view, but it is hard to precisely carve out the modified part from the JS API file, so this adds the whole file for the legacy spec.
rossberg
approved these changes
May 23, 2024
dschuff
approved these changes
May 23, 2024
|
I'm not strongly opinionated on the directory name either. The main reason I renamed it was in case there will be other proposals part of which may end up in this |
|
Will revert back to |
|
Yeah, I sincerely hope this doesn't become a regular thing. :) FWIW, I don't think proposal names are highly relevant for later spec matters, since they are historic and sometimes become inaccurate when a proposal evolves, see e.g. "bulk memory ops", "threads", etc. |
aheejin
added a commit
to aheejin/exception-handling
that referenced
this pull request
May 24, 2024
WebAssembly#303 broke the core spec links. This fixes it by adding `core/` to the directory links and also adds the JS API spec link to the web page.
aheejin
added a commit
that referenced
this pull request
May 25, 2024
#303 broke the core spec links. This fixes it by adding `core/` to the directory links and also adds the JS API spec link to the web page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
coreandjs-apidirectory indocument/legacy/exceptions, moves all core spec files intocore/, and restores the deleted legacy JS API files injs-api/.The core legacy spec only contains the EH instructions, which is easier to view, but it is hard to precisely carve out the modified part from the JS API file, so this adds the whole file for the legacy spec.