Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js-api] Sync with WPT tests #306

Merged
merged 4 commits into from
Jun 21, 2024
Merged

[js-api] Sync with WPT tests #306

merged 4 commits into from
Jun 21, 2024

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Jun 11, 2024

This reflects the WPT changes in
web-platform-tests/wpt@5623804 web-platform-tests/wpt@e0c0429 and web-platform-tests/wpt#42764

wasm-module-builder.js was not fully synced with the WPT repo; the changes reflected were just enough to pass the tests.

This also changes worker from dedicatedworker in legacy/exceptions/js-api/basic.tentative.any.js, even though the matching WPT test has not been updated to use it, because all other tests seem to be using dedicatedworker now.

This reflects the WPT changes in
web-platform-tests/wpt@5623804
web-platform-tests/wpt@e0c0429
and web-platform-tests/wpt#42764

This also changes `worker` from `dedicatedworker` in
`legacy/exceptions/js-api/basic.tentative.any.js`, even though the
matching WPT test has not been updated to use it, because all other
tests seem to be using `dedicatedworker` now.
@aheejin aheejin marked this pull request as draft June 11, 2024 01:24
@aheejin
Copy link
Member Author

aheejin commented Jun 11, 2024

Some tests are failing with WPT. Will fix it and mark it as ready for review.

@aheejin aheejin marked this pull request as ready for review June 21, 2024 07:20
@aheejin aheejin merged commit 901a9b0 into main Jun 21, 2024
1 check passed
@aheejin aheejin deleted the js_api_test_sync_wpt branch June 21, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants