Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing of ref.i31 in the appendix #530

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix typing of ref.i31 in the appendix #530

merged 1 commit into from
Mar 6, 2024

Conversation

fitzgen
Copy link
Contributor

@fitzgen fitzgen commented Mar 6, 2024

It produces a non-null (ref i31) not an i31ref aka (ref null i31).

@fitzgen
Fix typing of ref.i31 in the appendix
1705935 
It produces a non-null `(ref i31)` not an `i31ref` aka `(ref null i31)`.
rossberg
rossberg approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossberg rossberg merged commit aaa6718 into WebAssembly:main Mar 6, 2024
4 checks passed
@fitzgen fitzgen deleted the patch-2 branch March 6, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossberg rossberg rossberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fitzgen @rossberg