Add additional i31ref spec tests
#534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that Wasmtime was passing the spec tests despite having bits that were known to be unimplemented. This should help the tests exercise those corners of the spec. Notably: * Setting `i31ref` globals. * Initializing tables and globals with `(ref.i31 (global.get $g))`. * Table operations on `i31ref` tables. * Accessing `anyref` globals and tables that are actually `i31ref`s. This is interesting to exercise outside of general subtyping because we have different paths in our inline GC barriers for `anyref`s that are actually `i31ref`s.
rossberg
reviewed
Apr 5, 2024
There are a couple non-null types in there. Indeed, we avoid generating null-checks for GC barriers when we have non-null types. I think in an ideal world, yes, we would duplicate ~everything once for nullable and once more for non-nullable types. Don't really want to do that by hand though. Maybe if we were generating tests programmatically.
Done! |
rossberg
approved these changes
Apr 9, 2024
|
(I don't have write access and can't merge this PR myself) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Wasmtime was passing the spec tests despite having bits that were known to be unimplemented. This should help the tests exercise those corners of the spec.
Notably:
Setting
i31refglobals.Initializing tables and globals with
(ref.i31 (global.get $g)).Table operations on
i31reftables.Accessing
anyrefglobals and tables that are actuallyi31refs. This is interesting to exercise outside of general subtyping because we have different paths in our inline GC barriers foranyrefs that are actuallyi31refs.@rossberg PTAL