Add validation rules for Linking.md #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Oct 20, 2025
sbc100
reviewed
Oct 21, 2025
| If a data encoding for the relocation cannot be determined (i.e. there isn't a | ||
| known grammar construct at the relocation offset), the data encoding constraints | ||
| aren't applied. For example, this is the case for unknown custom sections and | ||
| data segments. |
There was a problem hiding this comment.
Would it be simpler to say that all the above restriction apply only the code secition?
I'm a little confused seeing "the data encoding constraints
aren't applied. For example, this is the case for unknown custom sections and
data segments." above and "In the CODE section, only certain .." below.
In all cases aren't all the limitations limited to the code section?
There was a problem hiding this comment.
No, there may be custom section relocations for which the assembler may be aware of the relocation formats. If, for example, we were to validate DWARF, we would also like to validate that the relocations there are valid too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #258, this PR adds additional rules for validation of object files to ensure that invalid relocations are not present in a valid object file.