-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c-writer.cc: Correctly handle label names when branching out of try block #2208
Conversation
5e2136b
to
c43aca6
Compare
c30965e
to
2346225
Compare
c43aca6
to
6de56e0
Compare
2346225
to
3d13d98
Compare
6de56e0
to
c73e927
Compare
3d13d98
to
0b82271
Compare
c73e927
to
1967551
Compare
0b82271
to
ec4566c
Compare
1967551
to
61ce5d2
Compare
ec4566c
to
52df1e0
Compare
61ce5d2
to
1bc6ed9
Compare
1bc6ed9
to
f11c61c
Compare
ec58755
to
7c2a457
Compare
Hmm... I'm afraid I don't understand this well enough to help review this, so I'll leave it up to @sbc100 |
@sbc100 are you able to give this a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubberstamp lgtm. I'm afraid I don't fulling understand this change either, but if this test passed after and fails before this sgtm.
Thank you! |
Sequenced behind #2207.Fixes #2205. wasm2c was making a LabelDecl with the raw Wasm name instead of the safe/unique C name. Because the label's C name is generated inBeginTry
but the LabelDecl doesn't come until later, it's probably easiest just to re-retrieve the C name at that point. Or we could haveBeginTry
actually return the generated C name (along with the mark)...The exception-handling proposal could benefit from better test coverage here (WebAssembly/exception-handling#210) but this is definitely our bug!