c-writer.cc: Correctly handle label names when branching out of try block #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithw
force-pushed
the
w2c-exception-bug
branch
from
5e2136b
to
c43aca6
Compare
keithw
force-pushed
the
w2c-cleanup-name-lookup
branch
from
c30965e
to
2346225
Compare
keithw
force-pushed
the
w2c-exception-bug
branch
from
c43aca6
to
6de56e0
Compare
keithw
force-pushed
the
w2c-cleanup-name-lookup
branch
from
2346225
to
3d13d98
Compare
keithw
force-pushed
the
w2c-exception-bug
branch
from
6de56e0
to
c73e927
Compare
keithw
force-pushed
the
w2c-cleanup-name-lookup
branch
from
3d13d98
to
0b82271
Compare
keithw
force-pushed
the
w2c-exception-bug
branch
from
c73e927
to
1967551
Compare
keithw
force-pushed
the
w2c-cleanup-name-lookup
branch
from
0b82271
to
ec4566c
Compare
keithw
force-pushed
the
w2c-exception-bug
branch
from
1967551
to
61ce5d2
Compare
keithw
force-pushed
the
w2c-cleanup-name-lookup
branch
from
ec4566c
to
52df1e0
Compare
keithw
force-pushed
the
w2c-exception-bug
branch
from
61ce5d2
to
1bc6ed9
Compare
keithw
force-pushed
the
w2c-exception-bug
branch
from
1bc6ed9
to
f11c61c
Compare
keithw
force-pushed
the
w2c-exception-bug
branch
3 times, most recently
from
ec58755
to
7c2a457
Compare
|
Hmm... I'm afraid I don't understand this well enough to help review this, so I'll leave it up to @sbc100 |
|
@sbc100 are you able to give this a review? |
sbc100
approved these changes
May 8, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequenced behind #2207.Fixes #2205. wasm2c was making a LabelDecl with the raw Wasm name instead of the safe/unique C name. Because the label's C name is generated inBeginTrybut the LabelDecl doesn't come until later, it's probably easiest just to re-retrieve the C name at that point. Or we could haveBeginTryactually return the generated C name (along with the mark)...The exception-handling proposal could benefit from better test coverage here (WebAssembly/exception-handling#210) but this is definitely our bug!