Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate the argv buffers with alloca instead of malloc. #121

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sunfishcode
Copy link
Member

This way, if an application doesn't otherwise use malloc, they don't
need to link in malloc.

Idea from #118 (comment)!

One thing I'm somewhat concerned by is the lack of error reporting in alloca. Perhaps that's a broader problem that we'll want to address anyway?

This way, if an application doesn't otherwise use malloc, they don't
need to link in malloc.

Idea from #118 (comment)!
@sunfishcode
Copy link
Member Author

I am considering waiting until __stack_limit is available (patch here), followed by a way to check for stack overflow in clang, before enabling this.

Base automatically changed from master to main January 19, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants