Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force-fetch tags in CI to fix git describe #410

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

alexcrichton
Copy link
Collaborator

My release attempt in #408 did not go well because the release artifacts were not named correctly. This fixes an issue described by actions/checkout#290 where checkouts of annotated tags overwrite the annotation which breaks git describe. That means that version detection is broken in CI during releases which causes artifacts to have the wrong information.

This applies the workaround described in that issue to git fetch --tags --force after the checkout step to undo the overwrite done in the checkout step.

My release attempt in WebAssembly#408 did not go well because the release artifacts
were not named correctly. This fixes an issue described by
actions/checkout#290 where checkouts of annotated tags overwrite the
annotation which breaks `git describe`. That means that version
detection is broken in CI during releases which causes artifacts to have
the wrong information.

This applies the workaround described in that issue to `git fetch --tags
--force` after the checkout step to undo the overwrite done in the
checkout step.
Copy link
Collaborator

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@abrown abrown merged commit b4f426a into WebAssembly:main Apr 15, 2024
5 checks passed
@alexcrichton alexcrichton deleted the fix-tags branch July 31, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants