Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Compile JSC on Windows and Linux as well #299

Closed
wants to merge 1 commit into from

Conversation

mathiasbynens
Copy link
Contributor

@sbc100
Copy link
Member

sbc100 commented Dec 8, 2017

Won't you need to remove the no_windows and no_linux args from line 1430?

Also, you'll need to make the use of xcrun conditional won't you? (since it doesn't exist on non-mac). Maybe xcrun isn't needed? Its not used for other cmake runs in this file.

@dschuff
Copy link
Member

dschuff commented Dec 8, 2017

I'll give this a try locally.

@mathiasbynens
Copy link
Contributor Author

Won't you need to remove the no_windows and no_linux args from line 1430?

Yes! Done.

I don’t feel qualified to deal with the xcrun issue, to be honest. Feel free to amend this patch.

@dschuff
Copy link
Member

dschuff commented Apr 19, 2021

Closing this as obsolete, and because we are moving the code (see #698). If there is an issue with the build scripts, please file an issue against EMSDK

@dschuff dschuff closed this Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants