proper call to static methods#45
Open
WordpressReady wants to merge 1 commit intoWebDevStudios:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm currently developing the NextCellent Gallery plugin and I found current Version NextGen Public Uploader is working fine with NextCellent. I tested the features and it is absolutely great!
The current request is trying to workaround a few issues since I'm working on PHP strict mode. I tried to be sure to call static methods properly without containing $this references.
What I did was simply activate strict mode and modify the plugin until there were no more error nor warnings.
Please notice the plugin was tested with NextCellent, but I didn't tested it with NextGen.
Also , this plugin allowed me to find two NextCellent errors due improper class use.
Please check if the concept is right for you and keep the good work!