REST API tests enhancements #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rclations
force-pushed
the
rest-api-tests-enhancements
branch
from
feb059a to
f578185
Compare
binarygary
reviewed
Jul 20, 2017
| @@ -31,6 +42,70 @@ function test_class_access() { | |||
| * @since <%= version %> | |||
| */ | |||
| function test_sample() { | |||
| /* | |||
There was a problem hiding this comment.
Sorry for such a lengthy delay on looking at this PR.
Can you please remove the commented code and I'll get this merged?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first-pass at #155
I'm not sure how you'd want to have a more comprehensive basic test setup, so I added a basic example in a block comment for now. Ideally I'd like to get your feedback on the approach you'd want to take here.