Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove current layout engine's unbreakable images quirk #39855

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Feb 1, 2025

b166313

Remove current layout engine's unbreakable images quirk
https://bugs.webkit.org/show_bug.cgi?id=286861
rdar://144018888

Reviewed by NOBODY (OOPS!).

Merge: https://source.chromium.org/chromium/chromium/src/+/88f301874fe22403ea3526f695cbe2cbab47f93a

This removes the unbreakable images quirk (where there is no break
opportunity between an image and a word), during the layout phase of
the current layout system.

* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
* LayoutTests/fast/table/unbreakable-images-quirk.html:
* LayoutTests/platform/mac/fast/table/unbreakable-images-quirk-expected.txt:

b166313

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=286861
rdar://144018888

Reviewed by NOBODY (OOPS!).

Merge: https://source.chromium.org/chromium/chromium/src/+/88f301874fe22403ea3526f695cbe2cbab47f93a

This removes the unbreakable images quirk (where there is no break
opportunity between an image and a word), during the layout phase of
the current layout system.

* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
* LayoutTests/fast/table/unbreakable-images-quirk.html:
* LayoutTests/platform/mac/fast/table/unbreakable-images-quirk-expected.txt:
@Ahmad-S792 Ahmad-S792 self-assigned this Feb 1, 2025
@Ahmad-S792 Ahmad-S792 added the Layout and Rendering For bugs with layout and rendering of Web pages. label Feb 1, 2025
@Ahmad-S792 Ahmad-S792 marked this pull request as draft February 1, 2025 18:38
@weinig
Copy link
Contributor

weinig commented Feb 1, 2025

Why does it make sense to remove this? What has changed?

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 1, 2025
@aproskuryakov
Copy link
Contributor

What is the motivation for this change? We don’t just merge Google changes when there is zero known benefit, as the risk is intrinsically non-zero.

@alanbaradlay
Copy link
Contributor

BreakingContext is not used for inline content anymore. SVG content is the only client here but with SVG we don't run line breaking so essentially this merge is no-op.

@Ahmad-S792 Ahmad-S792 closed this Feb 12, 2025
@Ahmad-S792 Ahmad-S792 deleted the eng/Remove-current-layout-engine-s-unbreakable-images-quirk branch February 13, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layout and Rendering For bugs with layout and rendering of Web pages. merging-blocked Applied to prevent a change from being merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants