Remove unused functions from LegacyInlineTextBox.cpp|h

[Ahmad-S792]

ccb1f42

Remove unused functions from `LegacyInlineTextBox.cpp|h`
https://bugs.webkit.org/show_bug.cgi?id=287334
rdar://144450111

Reviewed by Alan Baradlay.

This patch just removes unused functions and continue on path
of Legacy Layout clean-up.

* Source/WebCore/rendering/LegacyInlineTextBox.cpp:
(WebCore::LegacyInlineTextBox::logicalOverflowRect const): Deleted.
* Source/WebCore/rendering/LegacyInlineTextBox.h:
(WebCore::LegacyInlineTextBox::logicalTopVisualOverflow const): Deleted.
(WebCore::LegacyInlineTextBox::logicalBottomVisualOverflow const): Deleted.
(WebCore::LegacyInlineTextBox::logicalLeftVisualOverflow const): Deleted.
(WebCore::LegacyInlineTextBox::logicalRightVisualOverflow const): Deleted.

Canonical link: https://commits.webkit.org/290114@main

b9cc657

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash b9cc657)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[alanbaradlay]

We should put very little effort into cleaning up legacy at this point as Antti is going to make all of it go away in one go (unless there's some additional benefit(.

[Ahmad-S792]

We should put very little effort into cleaning up legacy at this point as Antti is going to make all of it go away in one go (unless there's some additional benefit(.

I just stumbled upon them so I thought why not. Good to know, it will soon go away in one full swoop. I will avoid touching it now.

[nt1m]

setLogicalOverflowRect, gTextBoxesWithOverflow can all be removed too it seems.

[Ahmad-S792]

'setLogicalOverflowRect' is used in LegacyInlineFlowBox.cpp, while 'gTextBoxesWithOverflow' is used in other areas. I would let Antti clean-up in one swoop.

[nt1m]

'setLogicalOverflowRect' is used in LegacyInlineFlowBox.cpp

That call site does nothing, since nothing reads from logicalOverflowRect(). Ditto for gTextBoxesWithOverflow...

[webkit-commit-queue]

Committed 290114@main (ccb1f42): https://commits.webkit.org/290114@main

Reviewed commits have been landed. Closing PR #40290 and removing active labels.