Switch to use icu 65.1, enable to provide filters data file path #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jul 15, 2020
Comment on lines
+27
to
+33
| config BR2_PACKAGE_ICU_FILTERS_DATA_PATH | ||
| string "Path to filters data file" | ||
| help | ||
| This option allows to define the path to a filters data | ||
| file. | ||
| Leave empty to not use this functionality. | ||
| endif |
There was a problem hiding this comment.
By default, it will increase the size of zImage (with ramfs) significantly.
As there is no default filter defined, it will generate full icu data e.g. it will increase icudata size by 22MB and zImage size by 10MB.
Please cross-check if this size increase is OK.
Comment on lines
+17
to
18
| # If someone needs to build it outside still mk file is able to support it | ||
| ICU_BUILD_ICUDATA = y |
There was a problem hiding this comment.
icudata.mk and Config.in may also be modified as it is always building icudata and not using pre-generated icudata from Metrological repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.