fix: standardize healthcheck to use curl across all Dockerfiles#1272
Open
thuanpham582002 wants to merge 1 commit intoWei-Shaw:mainfrom
Open
fix: standardize healthcheck to use curl across all Dockerfiles#1272thuanpham582002 wants to merge 1 commit intoWei-Shaw:mainfrom
thuanpham582002 wants to merge 1 commit intoWei-Shaw:mainfrom
Conversation
Replace wget-based healthchecks with curl in root Dockerfile and deploy/Dockerfile, and add consistent flags (-f -s --max-time 5) to the existing curl healthcheck in Dockerfile.goreleaser. curl is already installed in deploy/Dockerfile and Dockerfile.goreleaser; this commit adds curl to the root Dockerfile's apk install list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wget-based healthchecks withcurlin rootDockerfileanddeploy/Dockerfile-f -s --max-time 5) to the existingcurlhealthcheck inDockerfile.goreleasercurlto the rootDockerfile'sapk installlist (already present in the other two Dockerfiles)All three Dockerfiles now use the identical healthcheck command:
Test plan