알림 캐싱 오류 해결 & 반복 일정 추가 기능 구현 #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthrough여러 컴포넌트에 반복 일정 생성 기능이 추가되고, DatePicker 및 Popover의 동작과 스타일이 개선되었습니다. 라우터에 인증 가드가 적용되었으며, 일부 문서 파일과 UI 요소가 주석 처리되었습니다. NotificationPopover의 데이터 fetch 조건이 명확하게 변경되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ScheduleInput
participant RecurringScheduleModal
participant ParentComponent
User->>ScheduleInput: "반복 일정 추가" 버튼 클릭
ScheduleInput->>RecurringScheduleModal: 모달 오픈
User->>RecurringScheduleModal: 요일, 날짜, 시간 선택 후 "일정 생성" 클릭
RecurringScheduleModal->>ScheduleInput: 생성된 일정 목록 전달
ScheduleInput->>ParentComponent: onChange로 일정 목록 업데이트
ScheduleInput->>User: 성공 토스트 노출 및 UI 갱신
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20분 Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
🚀 오늘뭐해 Preview Deploy 완료! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
packages/design-system/src/pages/MypageSummaryCardDoc.tsx (1)
6-6: 불필요한 주석된 코드 제거 권장문서 파일이라 하더라도 사용하지 않는 코드가 주석으로 남아 있으면 가독성이 떨어집니다. 추후 예시 코드가 필요 없다면 해당 줄을 완전히 삭제해 주세요.
packages/design-system/src/pages/OngoingExperienceCardDoc.tsx (1)
6-6: 불필요한 주석된 코드 제거 고려
code상수가 더 이상 사용되지 않는다면 완전히 삭제해도 문서 예제 렌더링에 영향이 없습니다. 주석으로 남겨두면 향후 유지보수 시 불필요한 노이즈가 될 수 있습니다.packages/design-system/src/pages/UpcomingScheduleDoc.tsx (1)
5-8:code상수 주석 처리로 Playground 예시 코드 기능이 무력화됨상단 주석에서 Playground에서 사용할 예시 코드를 작성하라고 안내하지만 실제로
code변수를 주석 처리해 Playground 기능을 못 쓰게 만들었습니다.
Playground 기능을 유지하려면 다음 중 하나를 선택해 주세요.
code상수를 복원하고<DocCode code={code} />형태로 전달- 주석과 Playground 관련 안내 문구를 삭제하여 의도적으로 비활성화했음을 명확히 표현
-// const code = `예시 코드를 작성해주세요.`; +const code = `<UpcomingSchedule variant="primary">Click me</UpcomingSchedule>`; ... - <DocCode code={`<UpcomingSchedule variant="primary">Click me</UpcomingSchedule>`} /> + <DocCode code={code} />apps/what-today/src/components/experiences/DescriptionTextarea.tsx (1)
11-11: 임시 높이 고정값 적용 확인PR 설명에 언급된 대로 react-hook-form ref 충돌로 인한 임시 조치로 300px 고정 높이가 적용되었습니다. 향후 autoHeight 기능이 정상 작동하도록 개선이 필요합니다.
apps/what-today/src/components/experiences/RecurringScheduleModal.tsx (1)
70-84: 날짜 검증 로직에서 일관성 있는 동작을 보장하세요.시작 날짜 변경 시 종료 날짜를 초기화하는 동작이 사용자에게 혼란을 줄 수 있습니다. 종료 날짜 핸들러와 일관성을 위해 변경사항을 적용하지 않는 방식을 고려해보세요.
일관된 동작을 위해 다음과 같이 수정을 고려해보세요:
const handleStartDateChange = (date: Dayjs | null) => { - setStartDate(date); - // 시작 날짜가 설정되고 종료 날짜가 있을 때 검증 if (date && endDate) { if (date.isAfter(endDate, 'day')) { toast({ title: '날짜 설정 오류', description: '시작 날짜는 종료 날짜보다 빨라야 합니다.', type: 'error', }); - setEndDate(null); // 종료 날짜 초기화 + return; // 변경사항 적용하지 않음 } } + + setStartDate(date); };
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
apps/what-today/src/components/experiences/DescriptionTextarea.tsx(1 hunks)apps/what-today/src/components/experiences/RecurringScheduleModal.tsx(1 hunks)apps/what-today/src/components/experiences/ScheduleInput.tsx(3 hunks)apps/what-today/src/components/notification/NotificationPopover.tsx(1 hunks)apps/what-today/src/pages/experiences/index.tsx(1 hunks)apps/what-today/src/routes/index.tsx(1 hunks)packages/design-system/src/components/DatePicker.tsx(2 hunks)packages/design-system/src/components/popover/PopoverRoot.tsx(1 hunks)packages/design-system/src/pages/MypageProfileHeaderDoc.tsx(1 hunks)packages/design-system/src/pages/MypageSummaryCardDoc.tsx(1 hunks)packages/design-system/src/pages/OngoingExperienceCardDoc.tsx(1 hunks)packages/design-system/src/pages/UpcomingScheduleDoc.tsx(1 hunks)
🧰 Additional context used
🧠 Learnings (14)
📓 Common learnings
Learnt from: kjhyun0830
PR: What-Today-FE/What-Today#77
File: apps/what-today/src/pages/mypage/manage-activities/index.tsx:50-63
Timestamp: 2025-07-19T01:23:56.149Z
Learning: User kjhyun0830 follows an incremental development approach in What-Today project, implementing UI first and adding functionality in later iterations, as confirmed in PR #77 for the experience management page.
Learnt from: MyungJiwoo
PR: What-Today-FE/What-Today#119
File: apps/what-today/src/pages/mypage/edit-profile/index.tsx:63-92
Timestamp: 2025-07-24T08:30:12.556Z
Learning: MyungJiwoo indicated they will implement validation checks for the edit profile page (password confirmation validation) immediately after PR #119 is merged, following their incremental development approach.
Learnt from: MyungJiwoo
PR: What-Today-FE/What-Today#90
File: apps/what-today/src/pages/signup/index.tsx:67-71
Timestamp: 2025-07-21T05:32:48.443Z
Learning: MyungJiwoo plans to implement form validation using zod and react-hook-form in a future iteration rather than adding quick validation checks in the current signup page implementation in apps/what-today/src/pages/signup/index.tsx.
Learnt from: kjhyun0830
PR: What-Today-FE/What-Today#169
File: apps/what-today/src/hooks/useMyActivitiesQuery.ts:23-25
Timestamp: 2025-07-29T14:50:14.117Z
Learning: kjhyun0830은 What-Today 프로젝트에서 토스터 알림과 같은 UI 일관성이 필요한 기능들을 여러 페이지에 걸쳐 한 번에 수정하는 접근 방식을 선호한다.
Learnt from: Taeil08
PR: What-Today-FE/What-Today#125
File: packages/design-system/src/components/DatePicker.tsx:25-28
Timestamp: 2025-07-24T13:33:33.202Z
Learning: packages/design-system/src/components/DatePicker.tsx에서 Taeil08은 sr-only 클래스를 가진 div 요소가 달력 트리거 버튼의 세로 정렬에 필요하다고 설명했음. 이 요소를 제거하면 버튼 정렬이 깨지는 레이아웃 의존성이 있음.
Learnt from: MyungJiwoo
PR: What-Today-FE/What-Today#63
File: packages/design-system/src/pages/NoResultDoc.tsx:8-8
Timestamp: 2025-07-17T11:29:24.913Z
Learning: MyungJiwoo indicated that code duplication in documentation files (like design system documentation) is acceptable and doesn't need to be fixed, as it's not actual service code but rather demo/documentation code with different standards.
📚 Learning: the mainpage component in apps/what-today/src/pages/main/index.tsx contains placeholder/example code...
Learnt from: MyungJiwoo
PR: What-Today-FE/What-Today#43
File: apps/what-today/src/pages/main/index.tsx:7-7
Timestamp: 2025-07-14T13:36:17.941Z
Learning: The MainPage component in apps/what-today/src/pages/main/index.tsx contains placeholder/example code that will be modified later, including the fixed height class 'h-1400' which the user indicated is temporary.
Applied to files:
packages/design-system/src/pages/UpcomingScheduleDoc.tsxapps/what-today/src/components/experiences/DescriptionTextarea.tsxpackages/design-system/src/pages/OngoingExperienceCardDoc.tsxapps/what-today/src/pages/experiences/index.tsxapps/what-today/src/components/experiences/RecurringScheduleModal.tsxpackages/design-system/src/pages/MypageProfileHeaderDoc.tsxpackages/design-system/src/pages/MypageSummaryCardDoc.tsxapps/what-today/src/routes/index.tsx
📚 Learning: kjhyun0830 프로젝트에서 @what-today/design-system 패키지의 reservationstatus 타입이 calendar/index.ts에서 re-export...
Learnt from: kjhyun0830
PR: What-Today-FE/What-Today#91
File: apps/what-today/src/pages/mypage/reservations-status/index.tsx:2-2
Timestamp: 2025-07-22T03:59:52.657Z
Learning: kjhyun0830 프로젝트에서 @what-today/design-system 패키지의 ReservationStatus 타입이 calendar/index.ts에서 re-export되지 않아 메인 엔트리 포인트에서 접근할 수 없는 문제가 있음. DayCell.tsx에서 정의된 타입들을 calendar 모듈에서 명시적으로 export해야 함.
Applied to files:
packages/design-system/src/pages/UpcomingScheduleDoc.tsxpackages/design-system/src/pages/OngoingExperienceCardDoc.tsxapps/what-today/src/pages/experiences/index.tsxpackages/design-system/src/components/DatePicker.tsxapps/what-today/src/components/experiences/RecurringScheduleModal.tsxapps/what-today/src/components/experiences/ScheduleInput.tsxpackages/design-system/src/pages/MypageProfileHeaderDoc.tsxpackages/design-system/src/pages/MypageSummaryCardDoc.tsx
📚 Learning: packages/design-system/src/components/datepicker.tsx에서 taeil08은 sr-only 클래스를 가진 div 요소가 달력 트리거 버튼의 세...
Learnt from: Taeil08
PR: What-Today-FE/What-Today#125
File: packages/design-system/src/components/DatePicker.tsx:25-28
Timestamp: 2025-07-24T13:33:33.202Z
Learning: packages/design-system/src/components/DatePicker.tsx에서 Taeil08은 sr-only 클래스를 가진 div 요소가 달력 트리거 버튼의 세로 정렬에 필요하다고 설명했음. 이 요소를 제거하면 버튼 정렬이 깨지는 레이아웃 의존성이 있음.
Applied to files:
packages/design-system/src/pages/UpcomingScheduleDoc.tsxpackages/design-system/src/pages/OngoingExperienceCardDoc.tsxapps/what-today/src/pages/experiences/index.tsxpackages/design-system/src/components/DatePicker.tsxapps/what-today/src/components/experiences/RecurringScheduleModal.tsxapps/what-today/src/components/experiences/ScheduleInput.tsxpackages/design-system/src/pages/MypageProfileHeaderDoc.tsxpackages/design-system/src/pages/MypageSummaryCardDoc.tsxpackages/design-system/src/components/popover/PopoverRoot.tsx
📚 Learning: myungjiwoo indicated that code duplication in documentation files (like design system documentation)...
Learnt from: MyungJiwoo
PR: What-Today-FE/What-Today#63
File: packages/design-system/src/pages/NoResultDoc.tsx:8-8
Timestamp: 2025-07-17T11:29:24.913Z
Learning: MyungJiwoo indicated that code duplication in documentation files (like design system documentation) is acceptable and doesn't need to be fixed, as it's not actual service code but rather demo/documentation code with different standards.
Applied to files:
packages/design-system/src/pages/UpcomingScheduleDoc.tsxpackages/design-system/src/pages/OngoingExperienceCardDoc.tsxpackages/design-system/src/pages/MypageProfileHeaderDoc.tsxpackages/design-system/src/pages/MypageSummaryCardDoc.tsx
📚 Learning: in packages/design-system/src/components/button/index.tsx, harryseop uses handleclick wrapper for se...
Learnt from: HarrySeop
PR: What-Today-FE/What-Today#53
File: packages/design-system/src/components/button/index.tsx:32-41
Timestamp: 2025-07-16T06:51:15.152Z
Learning: In packages/design-system/src/components/button/index.tsx, HarrySeop uses handleClick wrapper for security purposes to prevent execution when users remove disabled attributes via developer tools. The onClick handler should be extracted from rest props before spreading to avoid being overwritten.
Applied to files:
packages/design-system/src/pages/OngoingExperienceCardDoc.tsxpackages/design-system/src/components/DatePicker.tsxpackages/design-system/src/pages/MypageSummaryCardDoc.tsxpackages/design-system/src/components/popover/PopoverRoot.tsx
📚 Learning: taeil08이 what-today 프로젝트의 체험 등록 페이지(apps/what-today/src/pages/experiences/iindex.tsx)에서 주소 입력 컴포넌트가 ...
Learnt from: Taeil08
PR: What-Today-FE/What-Today#134
File: apps/what-today/src/pages/experiences/iindex.tsx:11-16
Timestamp: 2025-07-25T03:14:08.579Z
Learning: Taeil08이 What-Today 프로젝트의 체험 등록 페이지(apps/what-today/src/pages/experiences/iindex.tsx)에서 주소 입력 컴포넌트가 아직 만들어지지 않아서 상태 관리를 나중에 추가할 예정이라고 언급함. 이는 프로젝트의 점진적 개발 접근법에 따른 것임.
Applied to files:
packages/design-system/src/pages/OngoingExperienceCardDoc.tsxapps/what-today/src/pages/experiences/index.tsxpackages/design-system/src/pages/MypageProfileHeaderDoc.tsxpackages/design-system/src/pages/MypageSummaryCardDoc.tsxapps/what-today/src/routes/index.tsx
📚 Learning: in the selectroot component (packages/design-system/src/components/select/selectroot.tsx), myungjiwo...
Learnt from: MyungJiwoo
PR: What-Today-FE/What-Today#57
File: packages/design-system/src/components/select/SelectRoot.tsx:37-38
Timestamp: 2025-07-17T01:20:26.915Z
Learning: In the SelectRoot component (packages/design-system/src/components/select/SelectRoot.tsx), MyungJiwoo questioned the need for implementing controlled component pattern. The current implementation only handles internal→external state changes via onChangeValue callback, but doesn't handle external→internal changes when the value prop is updated, which breaks the typical React controlled component contract.
Applied to files:
packages/design-system/src/pages/OngoingExperienceCardDoc.tsxapps/what-today/src/pages/experiences/index.tsxpackages/design-system/src/components/DatePicker.tsxapps/what-today/src/components/experiences/ScheduleInput.tsxpackages/design-system/src/pages/MypageProfileHeaderDoc.tsxpackages/design-system/src/pages/MypageSummaryCardDoc.tsxpackages/design-system/src/components/popover/PopoverRoot.tsx
📚 Learning: user kjhyun0830 prefers to keep temporary mock data inline in components when api integration is pla...
Learnt from: kjhyun0830
PR: What-Today-FE/What-Today#77
File: apps/what-today/src/pages/mypage/manage-activities/index.tsx:2-37
Timestamp: 2025-07-19T01:02:08.026Z
Learning: User kjhyun0830 prefers to keep temporary mock data inline in components when API integration is planned soon, rather than creating separate files for short-term code that will be deleted.
Applied to files:
packages/design-system/src/pages/OngoingExperienceCardDoc.tsxpackages/design-system/src/pages/MypageProfileHeaderDoc.tsx
📚 Learning: user kjhyun0830 follows an incremental development approach in what-today project, implementing ui f...
Learnt from: kjhyun0830
PR: What-Today-FE/What-Today#77
File: apps/what-today/src/pages/mypage/manage-activities/index.tsx:50-63
Timestamp: 2025-07-19T01:23:56.149Z
Learning: User kjhyun0830 follows an incremental development approach in What-Today project, implementing UI first and adding functionality in later iterations, as confirmed in PR #77 for the experience management page.
Applied to files:
apps/what-today/src/pages/experiences/index.tsx
📚 Learning: popovertrigger component in controlled mode (when open and onopenchange props are provided to popove...
Learnt from: MyungJiwoo
PR: What-Today-FE/What-Today#117
File: apps/what-today/src/components/notification/NotificationPopover.tsx:21-21
Timestamp: 2025-07-24T08:18:09.297Z
Learning: PopoverTrigger component in controlled mode (when open and onOpenChange props are provided to PopoverRoot) does not automatically toggle the popover state on click. The developer must provide a manual onClick handler to manage the state toggle, as the internal handleClick only works when !isControlled.
Applied to files:
apps/what-today/src/components/notification/NotificationPopover.tsxpackages/design-system/src/components/DatePicker.tsxapps/what-today/src/components/experiences/ScheduleInput.tsxpackages/design-system/src/components/popover/PopoverRoot.tsx
📚 Learning: in korean react calendar components, it's common to use english weekday abbreviations (s, m, t, etc....
Learnt from: kjhyun0830
PR: What-Today-FE/What-Today#31
File: packages/design-system/src/components/calendar/CalendarGrid.tsx:13-13
Timestamp: 2025-07-12T16:11:37.214Z
Learning: In Korean React calendar components, it's common to use English weekday abbreviations (S, M, T, etc.) while keeping month/year displays in Korean format. CalendarGrid can use dayjs.locale('en') for weekdays while CalendarHeader uses hardcoded Korean format strings like 'YYYY년 MM월', and these don't conflict since the Korean text is hardcoded in the format string.
Applied to files:
packages/design-system/src/components/DatePicker.tsxapps/what-today/src/components/experiences/RecurringScheduleModal.tsxapps/what-today/src/components/experiences/ScheduleInput.tsx
📚 Learning: in the radiogroup component (packages/design-system/src/components/radiogroup.tsx), the input type s...
Learnt from: Taeil08
PR: What-Today-FE/What-Today#35
File: packages/design-system/src/components/RadioGroup.tsx:0-0
Timestamp: 2025-07-13T13:18:33.545Z
Learning: In the RadioGroup component (packages/design-system/src/components/RadioGroup.tsx), the input type should be 'checkbox' rather than 'radio' to support the intended toggle behavior where users can click a selected option again to deselect it. The handleChange function already implements this toggle logic with `onSelect?.(isSelected ? '' : value);`.
Applied to files:
packages/design-system/src/components/DatePicker.tsx
📚 Learning: profileimageinput 컴포넌트(packages/design-system/src/components/profileimageinput.tsx)에서 previewurl은 의도...
Learnt from: MyungJiwoo
PR: What-Today-FE/What-Today#79
File: packages/design-system/src/components/ProfileImageInput.tsx:44-45
Timestamp: 2025-07-19T17:03:39.193Z
Learning: ProfileImageInput 컴포넌트(packages/design-system/src/components/ProfileImageInput.tsx)에서 previewUrl은 의도적으로 내부 상태로 관리됩니다. 이는 미리보기 이미지 관리와 API로 받아온 원본 이미지와의 비교를 위한 용도로, 외부에서 제어할 필요가 없는 uncontrolled 컴포넌트 + 콜백 패턴입니다.
Applied to files:
packages/design-system/src/pages/MypageProfileHeaderDoc.tsx
🔇 Additional comments (16)
packages/design-system/src/pages/MypageProfileHeaderDoc.tsx (1)
6-6: 불필요한 상수 주석 처리로 ESLint 경고 예방
사용되지 않는code상수를 주석 처리하여 불필요한 변수 선언이 제거되었습니다. 문서 페이지에서는 중복 코드가 허용된다는 이전 합의와도 충돌하지 않으며, 빌드·린팅 단계에서 발생할 수 있는 경고를 방지해 가독성과 품질을 높이는 적절한 수정입니다.packages/design-system/src/pages/UpcomingScheduleDoc.tsx (1)
25-30:variant,childrenprop 사용 여부 확인 필요27 라인의 예시 코드와 실제 29 라인의 렌더링이 상이합니다.
- 예시:
<UpcomingSchedule variant="primary">Click me</UpcomingSchedule>- 실제:
<UpcomingSchedule />
UpcomingSchedule컴포넌트가
•variant,children등을 지원하지 않으면 예시 코드가 오해를 줄 수 있고,
• 지원한다면 29 라인에서도 동일한 prop을 전달해 일관성을 유지해야 합니다.구현체를 다시 확인해 문서와 실코드가 일치하도록 조정해 주세요.
apps/what-today/src/components/notification/NotificationPopover.tsx (1)
75-75: 알림 캐싱 오류 해결이 올바르게 구현되었습니다
enabled: open옵션 추가로 팝오버가 열릴 때만 API 요청이 실행되도록 하여, 페이지 새로고침 없이도 최신 알림을 확인할 수 있게 되었습니다. React Query의 조건부 쿼리 기능을 적절히 활용한 해결책입니다.apps/what-today/src/pages/experiences/index.tsx (1)
314-314: 주석 처리된 라벨의 의도 확인 필요"예약 가능한 시간대" 라벨이 주석 처리되었습니다. 새로운 반복 일정 기능과 관련된 UI 조정인지, 아니면 임시 조치인지 확인이 필요합니다.
packages/design-system/src/components/popover/PopoverRoot.tsx (1)
153-155: 날짜 선택기 영역 클릭 시 팝오버 닫힘 방지 로직 추가
.date-picker클래스를 가진 요소 내부 클릭 시 팝오버가 닫히지 않도록 하는 로직이 추가되었습니다. 기존.select-content처리와 동일한 패턴으로 일관성 있게 구현되었습니다.apps/what-today/src/routes/index.tsx (1)
40-46: 체험 생성/수정 페이지에 인증 가드 적용체험 생성 및 수정 페이지가
authGuardLoader로 보호되어 로그인한 사용자만 접근할 수 있도록 변경되었습니다. 보안과 사용자 경험 개선에 적절한 조치입니다.packages/design-system/src/components/DatePicker.tsx (3)
17-24: 팝오버 상태 관리 및 자동 닫힘 기능 개선명시적인
isOpen상태 관리와 날짜 선택 시 팝오버가 자동으로 닫히는handleDateChange함수가 추가되어 사용자 경험이 크게 개선되었습니다.
29-44: 제어된 팝오버 구현 및 접근성 개선팝오버가 제어된 방식으로 구현되어
open과onOpenChangeprops를 통해 상태를 동기화합니다. disabled 상태를 고려한 클릭 핸들러도 적절히 구현되었습니다.
46-71: 달력 스타일링 및 날짜 상태 표시 개선
twMerge를 사용한 조건부 스타일링으로 선택된 날짜(primary-500), 오늘 날짜, 과거 날짜(비활성화)에 대한 시각적 피드백이 명확하게 구현되었습니다..date-picker클래스 추가로 PopoverRoot의 외부 클릭 처리와도 연동됩니다.apps/what-today/src/components/experiences/RecurringScheduleModal.tsx (3)
5-14: 인터페이스 정의가 적절합니다.
Time과Schedule인터페이스가 명확하게 정의되어 있고, 컴포넌트 전반에서 일관되게 사용되고 있습니다.
140-187: 일정 생성 로직의 무한루프 방지가 잘 구현되었습니다.1000일 제한을 통한 무한루프 방지와 날짜별 요일 확인 로직이 적절히 구현되어 있습니다. 스케줄 생성 후 폼 초기화와 성공 피드백도 적절합니다.
190-254: 팝오버 UI 구조가 잘 설계되었습니다.반응형 레이아웃과 접근성을 고려한 레이블링, 적절한 버튼 스타일링이 적용되어 있습니다. 모바일에서 종료 날짜 선택기가 잘릴 수 있다는 PR 설명의 문제는 향후 수정 예정으로 현재는 수용 가능합니다.
apps/what-today/src/components/experiences/ScheduleInput.tsx (4)
3-5: 컴포넌트 임포트가 적절합니다.
useState추가와RecurringScheduleModal임포트가 올바르게 되어 있습니다.
44-58: 반복 일정 처리 로직이 잘 구현되었습니다.기존 스케줄과 새 스케줄을 합치는 로직이 적절하고, 빈 행을 필터링하는 부분도 올바르게 처리되었습니다. 성공 토스트도 적절히 표시됩니다.
144-153: 헤더 섹션 추가가 UX를 개선합니다."예약 가능한 시간대" 레이블과 반복 일정 추가 버튼을 나란히 배치한 레이아웃이 직관적입니다. 팝오버 상태 관리도 적절히 연결되어 있습니다.
154-210: 기존 스케줄 렌더링 로직이 잘 유지되었습니다.반복 일정 기능 추가에도 불구하고 기존의 스케줄 입력, 검증, 삭제 로직이 그대로 유지되어 있어 기존 기능에 영향을 주지 않습니다. 조건부 버튼 렌더링도 적절합니다.
|
🚀 오늘뭐해 Preview Deploy 완료! |
Taeil08
approved these changes
Aug 2, 2025
Contributor
|
예약 거절 알림 해결하셨군요 캐싱 너무 잘하시는데요? ㅋㅋㅋㅋ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 관련 이슈 번호
📌 작업 내용
enabled으로 팝오버가 뜰 때만 API를 요청하도록 수정했습니다.primary-500으로 구분되게 했습니다.✅ 체크리스트
📷 UI 변경 사항 (선택)
❓무슨 문제가 발생했나요? (선택)
💬 기타 참고 사항 (선택)
Summary by CodeRabbit
신규 기능
기능 개선
버그 수정
UI/문서
접근성 및 보안