메인페이지 카드 개수 수정 #215
Merged
메인페이지 카드 개수 수정 #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughMainPage 컴포넌트가 대규모로 리팩터링되어 상태 관리와 성능, 코드 명확성이 개선되었습니다. 검색, 필터, 정렬, 페이지네이션 로직이 useMemo와 useCallback을 활용해 통합 및 최적화되었으며, 불필요한 상태와 useEffect가 제거되었습니다. MobileCarousel 컴포넌트가 삭제되었고, MainCard 이미지에 lazy loading이 추가되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MainPage
participant ActivitiesAPI
participant Carousel
participant MainCard
User->>MainPage: 페이지 진입/검색/정렬/카테고리/페이지 변경
MainPage->>ActivitiesAPI: 활동 목록 쿼리 (최대 100개)
ActivitiesAPI-->>MainPage: 활동 데이터 반환
MainPage->>MainPage: useMemo로 필터/정렬/페이지네이션 처리
MainPage->>Carousel: 인기 활동 전달 (정렬된 데이터)
MainPage->>MainCard: 카드 렌더링 (React.memo 활용)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (9)📓 Common learnings📚 Learning: the mainpage component in apps/what-today/src/pages/main/index.tsx contains placeholder/example code...Applied to files:
📚 Learning: myungjiwoo encountered multiple api calls when adding all dependencies to useeffect in oauth callbac...Applied to files:
📚 Learning: harryseop encountered a scroll restoration issue in the usebodyscrolllock hook where the base page j...Applied to files:
📚 Learning: taeil08이 what-today 프로젝트의 체험 등록 페이지(apps/what-today/src/pages/experiences/iindex.tsx)에서 주소 입력 컴포넌트가 ...Applied to files:
📚 Learning: user kjhyun0830 follows an incremental development approach in what-today project, implementing ui f...Applied to files:
📚 Learning: in the selectroot component (packages/design-system/src/components/select/selectroot.tsx), myungjiwo...Applied to files:
📚 Learning: in the radiogroup component (packages/design-system/src/components/radiogroup.tsx), the input type s...Applied to files:
📚 Learning: in the radiogroup component (packages/design-system/src/components/radiogroup.tsx), when using type=...Applied to files:
🔇 Additional comments (8)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
🚀 오늘뭐해 Preview Deploy 완료! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
MyungJiwoo
approved these changes
Aug 2, 2025
Contributor
MyungJiwoo
left a comment
MyungJiwoo
left a comment
There was a problem hiding this comment.
현재 체험 등록/수정시 메인 페이지에서 새로고침을 해야만 반영되는 오류가 있었는데, 쿼리키를 바꿨으니 잘 되길 바랍니다..! 고생하셨어요!~
|
🚀 오늘뭐해 Preview Deploy 완료! |
This was referenced Aug 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 관련 이슈 번호
📌 작업 내용
✅ 체크리스트
📷 UI 변경 사항 (선택)
2025-08-02.7.27.00.mov
❓무슨 문제가 발생했나요? (선택)
-Issue로는 데스크탑에선 페이지네이션 4페이지로 갈때 조금 느립니다 데스크탑일떄는 4페이지(아이템개수:8 * 3페이지)
태블릿일때는 7페이지(아이템개수:4 *6페이지) 모바일일떄는(아이템 개수:6 * 4페이지) 5페이지에서 렉이 좀 걸리는데 각 페이지 별로 렉 걸리는 카드개수 시점이 24개까진 괜찮은데 25개째부터 나오는 페이지로 넘어갈때 렉이 좀 걸립니다.
💬 기타 참고 사항 (선택)
Summary by CodeRabbit
Summary by CodeRabbit
Refactor
Bug Fixes
New Features
Chores