Skip to content

Conversation

@kjhyun0830
Copy link
Contributor

@kjhyun0830 kjhyun0830 commented Aug 3, 2025

🧩 관련 이슈 번호

📌 작업 내용

  • 체험 관리 페이지 토스트 구현 (체험 삭제)
  • 예약 현황 페이지 토스트 구현 (예약 승인. 거절)
  • 예약 승인, 거절 시 캘린더 뱃지 자동반영 구현

✅ 체크리스트

  • PR 하기 전에 이슈에서 빼먹은건 없는지 확인했습니다
    • 라벨 및 마일스톤을 사이드 탭에서 등록했습니다.
  • PR을 보내는 브랜치가 올바른지 확인했습니다.
  • 팀원들이 리뷰하기 쉽도록 설명을 자세하게 작성했습니다.
  • 변경사항을 충분히 테스트 했습니다.
  • (함수를 구현 했을 때) JSDoc을 양식에 맞춰서 작성했습니다.
  • 컨벤션에 맞게 구현했습니다.

📷 UI 변경 사항 (선택)

2025-08-04.1.26.45.mov
2025-08-04.12.50.25.mov
2025-08-04.12.50.39.mov

❓무슨 문제가 발생했나요? (선택)

💬 기타 참고 사항 (선택)

Summary by CodeRabbit

  • New Features

    • 예약 승인/거절 및 활동 삭제 시 성공 및 실패에 대한 토스트 알림이 추가되었습니다.
  • Refactor

    • 사용되지 않는 주석 처리된 함수와 관련 코드가 제거되었습니다.

@kjhyun0830 kjhyun0830 added this to the 5차 스프린트 milestone Aug 3, 2025
@kjhyun0830 kjhyun0830 added the ✨ Feat 기능 구현 label Aug 3, 2025
@kjhyun0830 kjhyun0830 linked an issue Aug 3, 2025 that may be closed by this pull request
@coderabbitai
Copy link

coderabbitai bot commented Aug 3, 2025

📝 Walkthrough

Walkthrough

이 변경 사항은 예약 승인/거절 및 활동 삭제 시 성공과 실패에 대한 토스트 알림을 추가합니다. 또한 예약 상태 변경 시 월간 스케줄 쿼리 무효화가 포함되었습니다. 주석 처리된 불필요한 함수도 제거되었습니다.

Changes

Cohort / File(s) Change Summary
토스트 알림 및 쿼리 무효화 추가
apps/what-today/src/components/reservations-status/ReservationSheet.tsx
예약 승인/거절 시 성공·실패 토스트 알림 추가, 월간 스케줄 쿼리 무효화, 기존 콘솔 에러 로그를 토스트로 대체, useToast 훅 도입
토스트 알림 추가
apps/what-today/src/pages/mypage/manage-activities/index.tsx
활동 삭제 성공·실패 시 토스트 알림 추가, useToast 훅 도입, 기존 로직에는 영향 없음
불필요한 주석 함수 제거
apps/what-today/src/pages/mypage/reservations-status/index.tsx
주석 처리된 handleMonthChange 함수 및 관련 코드 완전 삭제, 그 외 로직 변화 없음

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ReservationSheet
    participant API
    participant Toast

    User->>ReservationSheet: 승인 또는 거절 버튼 클릭
    ReservationSheet->>API: 예약 상태 PATCH 요청
    alt 성공
        ReservationSheet->>Toast: 성공 토스트 표시
        ReservationSheet->>Query: 예약/일간/월간 스케줄 쿼리 무효화
    else 실패
        ReservationSheet->>Toast: 에러 토스트 표시
    end
Loading
sequenceDiagram
    participant User
    participant ManageActivitiesPage
    participant API
    participant Toast

    User->>ManageActivitiesPage: 활동 삭제 요청
    ManageActivitiesPage->>API: 삭제 요청
    alt 성공
        ManageActivitiesPage->>Toast: 성공 토스트 표시
    else 실패
        ManageActivitiesPage->>Toast: 에러 토스트 표시
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

📮 Api

Suggested reviewers

  • Taeil08
  • MyungJiwoo

Poem

🐇
토스트가 울려 퍼지는 밤,
승인과 삭제에 반짝이는 알림~
에러도 성공도 놓치지 않고,
토끼는 귀를 쫑긋 세웠지요.
달콤한 변화, 오늘도 hop hop!
🎉

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0031b43 and 20e1f03.

📒 Files selected for processing (2)
  • apps/what-today/src/pages/mypage/manage-activities/index.tsx (3 hunks)
  • apps/what-today/src/pages/mypage/reservations-status/index.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/what-today/src/pages/mypage/reservations-status/index.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/what-today/src/pages/mypage/manage-activities/index.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/kjhyun/230

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or @coderabbitai 요약 to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Aug 3, 2025

🚀 오늘뭐해 Preview Deploy 완료!
👉 미리보기 링크

@kjhyun0830 kjhyun0830 self-assigned this Aug 4, 2025
Copy link
Member

@HarrySeop HarrySeop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

🚀 오늘뭐해 Preview Deploy 완료!
👉 미리보기 링크

@kjhyun0830 kjhyun0830 merged commit 9e80ed6 into develop Aug 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feat 기능 구현

Projects

None yet

Development

Successfully merging this pull request may close these issues.

체험관리, 예약현황 페이지 토스트 적용

3 participants