Improvements in case of negative speed and current #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I saw the issue in chats, but I'd suggest to split this configuration to two different, one setting is for Speed, other setting is for Current |
Author
|
I thought about this option, but as I wrote above - the speed cannot be negative in principle. It does not make sense. So there will be one more extra setting. |
Contributor
|
Negative speed is helpful when you need to find starting point in logs, e.g. drag race, when it is started from tick tock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with Patton-S, the speed value is negative, and the current is correct. To make it work at least somehow, you need to enable the current and speed reverser. In this case, the speed is normal, and the current is reversed. If you enable absolute values, then the current will never be negative (which happens when braking) and the consumption will be calculated incorrectly. But negative speed does not make sense. Therefore, I suggest using the setting to reverse only the current value, and always make the speed absolute.