Skip Build and Deploy jobs on forks instead of failing them #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this addition, with more 'meta' changes like this I'll wait till Isaac provides feedback though. Otherwise I approve! |
.github/workflows/mdbook.yml
Outdated
| @@ -16,6 +16,7 @@ concurrency: | |||
|
|
|||
| jobs: | |||
| build: | |||
| if: github.repository == 'Whisky-App/whisky-book' | |||
There was a problem hiding this comment.
This should just be skipping the deployment step and not the build step. It's still valuable to make sure that build is working as intended on forks.
There was a problem hiding this comment.
I have tried it but it fails on my fork always at least.
There was a problem hiding this comment.
Skip the setup pages step, but not the entire job
JoshuaBrest
suggested changes
Jan 10, 2025
|
This is the output of a conditional applied to the Build job:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type(s)
Verification
Have you
./scripts/generate.mjs?./scripts/lint.mjs?This PR addresses an issue where a push to a forked repo causes error and a notification with such on GitHub. As we build and deploy only from the main repo it may reduce frustration produced by the constant errors sent to the regular contributors. This fix switches from error notifications to "job skipped" notifications.