CAEA support

django_afip/models.py

@@ -1502,6 +1502,17 @@ def is_validated(self) -> bool:
             return self.validation.result == ReceiptValidation.RESULT_APPROVED
         except ReceiptValidation.DoesNotExist:
             return False
+
+    @property
+    def ready_to_print(self)->bool:
+        if "CAEA" in self.point_of_sales.issuance_type:
+            return True
+
+        if (
+            "CAE" in self.point_of_sales.issuance_type
+            and self.is_validated
+        ):
+            return True
 
     def validate(self, ticket: AuthTicket = None, raise_=False) -> list[str]:
         """Validates this receipt.

django_afip/signals.py

@@ -2,9 +2,11 @@
 from django.db.models.signals import pre_save
 from django.dispatch import receiver
 
+
 from django_afip import exceptions
 from django_afip import models
 
+import datetime
 
 @receiver(pre_save, sender=models.TaxPayer)
 def update_certificate_expiration(sender, instance: models.TaxPayer, **kwargs):
@@ -15,30 +17,31 @@ def update_certificate_expiration(sender, instance: models.TaxPayer, **kwargs):
 @receiver(post_save, sender=models.ReceiptPDF)
 def generate_receipt_pdf(sender, instance: models.ReceiptPDF, **kwargs):
     if not instance.pdf_file:
-        if "CAEA" in instance.receipt.point_of_sales.issuance_type:
-            instance.save_pdf(save_model=True)
-        if (
-            "CAE" in instance.receipt.point_of_sales.issuance_type
-            and instance.receipt.is_validated
-        ):
+        if instance.receipt.ready_to_print:
             instance.save_pdf(save_model=True)
 
 
 @receiver(pre_save, sender=models.Receipt)
 def save_caea_data(sender, instance: models.TaxPayer, **kwargs):
-    if "CAEA" in instance.point_of_sales.issuance_type:
-        if instance.caea == "" or instance.caea == None:
-            caea = models.Caea.objects.all().filter(active=True)
-            if caea.count() != 1:
-                raise exceptions.CaeaCountError
-            else:
-                if instance.caea == None or instance.caea == "":
-                    instance.caea = caea[0]
-
-            if instance.receipt_number == None or instance.receipt_number == "":
-                counter = models.CaeaCounter.objects.get_or_create(
-                    pos=instance.point_of_sales, receipt_type=instance.receipt_type
-                )[0]
-                instance.receipt_number = counter.next_value
-                counter.next_value += 1
-                counter.save()
+    if "CAEA" not in instance.point_of_sales.issuance_type:
+        return
+
+    if instance.caea == "" or instance.caea == None:
+        date = datetime.datetime.now()
+        period = date.today().strftime("%Y%m")
+        order = 1
+        if date.day > 15:
+            order = 2
+        caea = models.Caea.objects.all().filter(active=True, taxpayer = instance.point_of_sales.owner, period=int(period), order=order)
+        if caea.count() != 1:
+            raise exceptions.CaeaCountError
+        else:
+            if instance.caea == None or instance.caea == "":
+                instance.caea = caea[0]
+        if instance.receipt_number == None or instance.receipt_number == "":
+            counter,_ = models.CaeaCounter.objects.get_or_create(
+                pos=instance.point_of_sales, receipt_type=instance.receipt_type
+            )
+            instance.receipt_number = counter.next_value
+            counter.next_value += 1
+            counter.save()

tests/test_models.py

@@ -1,4 +1,5 @@
 from datetime import datetime
+from django.utils.timezone import make_aware
 from unittest.mock import MagicMock
 from unittest.mock import call
 from unittest.mock import patch
@@ -9,7 +10,7 @@
 from django_afip import exceptions
 from django_afip import factories
 from django_afip import models
-from django_afip.factories import ReceiptFactory
+from django_afip.factories import CaeaFactory, ReceiptFactory, TaxPayerFactory, SubFactory
 from django_afip.factories import ReceiptValidationFactory
 from django_afip.factories import ReceiptWithApprovedValidation
 from django_afip.factories import ReceiptWithInconsistentVatAndTaxFactory
@@ -629,3 +630,54 @@ def test_receipt_entry_gt_total_discount():
 
     with pytest.raises(Exception, match=r"\bdiscount_less_than_total\b"):
         factories.ReceiptEntryFactory(quantity=1, unit_price=1, discount=2)
+
+@pytest.mark.django_db
+@pytest.mark.este
+def test_bad_retrive_caea():
+    """
+    Test that in the way that the CAEA is assigned in the save signal even if
+    there are multiple taxpayer with 1 CAEA each the code assigned well.
+
+    It not ensure that if the same taxpayer has multiples actives CAEAs the correct will be assigned
+
+    """
+    caea_good = CaeaFactory()
+    caea_bad = CaeaFactory(
+        caea_code = "12345678974188",
+        valid_since = make_aware(datetime(2022, 5, 15)),
+        expires = make_aware(datetime(2022, 5, 30)),
+        generated = make_aware(datetime(2022, 5, 30, 21, 6, 4)),
+        taxpayer = TaxPayerFactory(
+            name = "Jane Doe",
+            cuit = 20366642330,
+        )
+    )
+
+    pos = factories.PointOfSalesFactoryCaea()
+    receipt = factories.ReceiptFactory(point_of_sales=pos)
+
+    assert caea_bad.caea_code != receipt.caea.caea_code
+
+@pytest.mark.django_db
+@pytest.mark.este
+def test_caea_assigned_receipt_correct():
+    """
+    Test that even if a taxpayer has multiples actives CAEAs the correct will be assigned
+    """
+    caea_good = CaeaFactory()
+    caea_bad = CaeaFactory(
+        caea_code = "12345678974188",
+        period = 202209,
+        order = "1",
+        valid_since = make_aware(datetime(2022, 4, 15)),
+        expires = make_aware(datetime(2022, 4, 30)),
+        generated = make_aware(datetime(2022, 4, 14, 21, 6, 4)),
+    )
+
+    assert caea_bad != caea_good
+
+    pos = factories.PointOfSalesFactoryCaea()
+    receipt = factories.ReceiptFactory(point_of_sales=pos)
+
+    assert caea_bad.caea_code != receipt.caea.caea_code
+    assert models.Caea.objects.all().filter(active=True, taxpayer = receipt.point_of_sales.owner).count() == 2