Skip to content

[WE-624] Drop REL1_39 support - #9

Merged
tosfos merged 1 commit into
masterfrom
WE-624
Oct 28, 2026
Merged

tosfos merged 1 commit into
masterfrom
WE-624

Conversation

@tosfos

@tosfos tosfos commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Drops REL1_39 from CI per WE-624, as directed by the ticket. REL1_35 support is retained (PHPUnit include leg untouched), so extension.json still requires >= 1.35.0.

Changes (.github/workflows/ci.yml only)

  • Phan (security) job: matrix mediawiki: [ REL1_39, REL1_43 ] → [ REL1_43 ]; removed the now-dead exclusion for php: 8.3 / mediawiki: REL1_39 (and its explanatory comment).
  • PHPUnit (test) job: matrix mediawiki: [ REL1_39, REL1_43 ] → [ REL1_43 ]. The include leg that tests MW 1.35 with PHP 7.4 and the 7.4/REL1_43 exclusion are unchanged.

Notes

  • extension.json deliberately left unchanged: its requires.MediaWiki is >= 1.35.0, and the ticket requires keeping REL1_35 support.
  • Validation: ci.yml parses via yaml.safe_load (matrices verified post-edit) and extension.json parses via json.load; no REL1_39 references remain in the workflow.
  • Out-of-scope observations (not changed, per "nothing else"): test helpers still branch on MW_VERSION >= 1.39 (tests/phpunit/integration/WikiExtensionsTest.php, WikiExtensionsApiTest.php) and a comment in includes/SpecialExtensions.php mentions Phan running on 1.39.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f0c5bd46-4d7f-426b-87b1-6c91d0e39276


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tosfos
tosfos merged commit 6181340 into master Oct 28, 2026
7 of 8 checks passed
@tosfos
tosfos deleted the WE-624 branch October 28, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant