Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooktest #2505

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Webhooktest #2505

wants to merge 11 commits into from

Conversation

sczerwinski-wikia
Copy link

No description provided.

@@ -67,7 +67,8 @@ private AssertionMessages() {
+ ".wds-global-navigation__user-logged-in .wds-avatar img";

private static final String WDS_FOOTER_HEADER_CLASS = "wds-global-footer__header";
private static final By MERCURY_SKIN = By.cssSelector(".mobile-wiki");
// private static final By MERCURY_SKIN = By.cssSelector("#ember-container, .mobile-wiki");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR This block of commented-out lines of code should be removed. rule

@WikiaTech
Copy link

SonarQube analysis reported 4 issues

  • MAJOR 1 major
  • MINOR 2 minor
  • INFO 1 info

Watch the comments in this conversation to review them.

3 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR CommunityHeaderTests.java#L59: Define a constant instead of duplicating this literal "Special:WikiActivity" 3 times. rule
  2. MINOR CommunityHeaderTests.java#L70: Define a constant instead of duplicating this literal "Special:Videos" 3 times. rule
  3. INFO WikiBasePageObject.java#L143: Complete the task associated to this TODO comment. rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants