Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seo 670 new tests #2517

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Seo 670 new tests #2517

wants to merge 13 commits into from
+325 −13

Conversation

sczerwinski-wikia
Copy link

No description provided.

WikiaTech
WikiaTech reviewed Nov 14, 2018
View reviewed changes
...est/java/com/wikia/webdriver/testcases/desktop/categoriestests/DynamicCategoryPageTests.java


public void dynamicCategoryAnonNotAbleToChangeLayout() {
new ArticlePageObject().open("Category:200elements");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Define a constant instead of duplicating this literal "Category:200elements" 4 times. rule

WikiaTech
WikiaTech reviewed Nov 14, 2018
View reviewed changes
...est/java/com/wikia/webdriver/testcases/desktop/categoriestests/DynamicCategoryPageTests.java

DynamicCategoryPage categoryPage = new DynamicCategoryPage();
CategoryLayoutSelector layoutSelector = categoryPage.getLayoutSelector();
Assertion.assertFalse(layoutSelector.isVisible(), "Layout selectors are displayed for anon");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Define a constant instead of duplicating this literal "Layout selectors are displayed for anon" 3 times. rule

@WikiaTech
Copy link

SonarQube analysis reported 10 issues

  • MAJOR 5 major
  • MINOR 5 minor

Watch the comments in this conversation to review them.

8 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR BasePageObject.java#L171: Either log or rethrow this exception. rule
  2. MAJOR BasePageObject.java#L339: Either log or rethrow this exception. rule
  3. MAJOR BasePageObject.java#L642: Remove this unused private "getTabsCount" method. rule
  4. MAJOR BasePageObject.java#L703: Remove this unused "initialTabsNumber" local variable. rule
  5. MAJOR CategoryPageTest.java#L100: This block of commented-out lines of code should be removed. rule
  6. MINOR CategoryPageTest.java#L24: Define a constant instead of duplicating this literal "Category:%s" 5 times. rule
  7. MINOR CategoryPageTest.java#L27: Define a constant instead of duplicating this literal "[[%s]]" 7 times. rule
  8. MINOR CategoryPageTest.java#L43: Define a constant instead of duplicating this literal "some irrelevant content of category article" 3 times. rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiaTech WikiaTech WikiaTech left review comments

@nikodamn nikodamn Awaiting requested review from nikodamn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sczerwinski-wikia @WikiaTech