Skip to content

show individual name rather than uuid in bulk import listing#1249

Merged
JasonWildMe merged 2 commits intomainfrom
1248_bulk_import_listing_indiv_name
Sep 23, 2025
Merged

show individual name rather than uuid in bulk import listing#1249
JasonWildMe merged 2 commits intomainfrom
1248_bulk_import_listing_indiv_name

Conversation

@naknomum
Copy link
Copy Markdown
Member

  • add individualDisplayName to each encounter in api for bulk import tasks
  • frontend displays above instead of uuid

PR fixes #1248

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.59%. Comparing base (1cb991a) to head (a25c106).
⚠️ Report is 778 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/pages/BulkImport/BulkImportTask.jsx 0.00% 3 Missing ⚠️
src/main/java/org/ecocean/api/BulkImport.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main   #1249      +/-   ##
==========================================
- Coverage     8.59%   8.59%   -0.01%     
  Complexity     939     939              
==========================================
  Files          623     623              
  Lines        67991   67993       +2     
  Branches     12492   12493       +1     
==========================================
  Hits          5845    5845              
- Misses       61548   61550       +2     
  Partials       598     598              
Flag Coverage Δ
backend 8.59% <0.00%> (-0.01%) ⬇️
frontend 8.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erinz2020 erinz2020 marked this pull request as ready for review September 22, 2025 15:39
@erinz2020 erinz2020 requested a review from vkirkl September 22, 2025 15:40
@@ -115,6 +115,7 @@ const BulkImportTask = observer(() => {
user: item.submitter?.displayName || "-",
occurrenceID: item.occurrenceId || "-",
individualID: item.individualId || "-",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean to keep individualID here and add individualName? Or replace individualID with individualName?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a double check: is there the possibility for more confusion here?

Could the user enter in their spreadsheet:

"Bob"

our logic reconciles "Bob" to individual <some_UUID>

we then return that individual's display name, which is a complex set of logic that might return some other value like "MX-4567"?

Is it worth just showing the Excel field value "Bob" so long as it can be validated to an existing individual's UUID?

Copy link
Copy Markdown
Collaborator

@JasonWildMe JasonWildMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JasonWildMe JasonWildMe merged commit b531260 into main Sep 23, 2025
1 check passed
@JasonWildMe JasonWildMe deleted the 1248_bulk_import_listing_indiv_name branch September 23, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display Individual IDs instead of UUIDs in bulk import table in 10.8

5 participants