Skip to content

validation error for projectIdPrefix / researchProjectName#1379

Merged
JasonWildMe merged 11 commits intomainfrom
1314_bulk_import_project_fix
Apr 20, 2026
Merged

validation error for projectIdPrefix / researchProjectName#1379
JasonWildMe merged 11 commits intomainfrom
1314_bulk_import_project_fix

Conversation

@naknomum
Copy link
Copy Markdown
Member

@naknomum naknomum commented Jan 14, 2026

PR fixes #1314

frontend:

  1. for column projectIdPrefix and researchProjectName, they must appear at the same time, if only one column was uploaded, error will be flagged
  2. if only one column has value, error will also be flagged

@erinz2020
Copy link
Copy Markdown
Contributor

@claude can you help to review this pr

@claude

This comment was marked as outdated.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 43.75000% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.67%. Comparing base (d3e791f) to head (a66b258).

Files with missing lines Patch % Lines
frontend/src/pages/BulkImport/BulkImportStore.js 35.00% 17 Missing and 9 partials ⚠️
...rontend/src/pages/BulkImport/EditableDataTable.jsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
- Coverage   50.72%   50.67%   -0.05%     
==========================================
  Files         281      281              
  Lines       10476    10521      +45     
  Branches     3248     3262      +14     
==========================================
+ Hits         5314     5332      +18     
- Misses       4895     4913      +18     
- Partials      267      276       +9     
Flag Coverage Δ
backend 50.67% <43.75%> (-0.05%) ⬇️
frontend 50.67% <43.75%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erinz2020
Copy link
Copy Markdown
Contributor

@claude translation error fixed

@claude

This comment was marked as outdated.

@erinz2020 erinz2020 marked this pull request as ready for review April 20, 2026 15:08
@JasonWildMe JasonWildMe merged commit 86600bf into main Apr 20, 2026
2 checks passed
@JasonWildMe JasonWildMe deleted the 1314_bulk_import_project_fix branch April 20, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If project field is missing from bulk import, it doesn't get flagged during validation

4 participants