Skip to content

fix for: api (and other things) possibly returning duplicate MediaAssets#1403

Merged
naknomum merged 4 commits intomainfrom
fix_for_encounter_api_duplicate_assets
May 8, 2026
Merged

fix for: api (and other things) possibly returning duplicate MediaAssets#1403
naknomum merged 4 commits intomainfrom
fix_for_encounter_api_duplicate_assets

Conversation

@naknomum
Copy link
Copy Markdown
Member

  • enc.getMedia() did not check for duplicates in assets returned; now will not populate with duplicates
  • fixes encounter api sometimes producing duplicate asset data

@naknomum naknomum marked this pull request as ready for review January 26, 2026 23:11
Copy link
Copy Markdown
Contributor

@erinz2020 erinz2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.61%. Comparing base (c391d50) to head (0f0ba66).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1403   +/-   ##
=======================================
  Coverage   51.61%   51.61%           
=======================================
  Files         308      308           
  Lines       11976    11976           
  Branches     3824     3824           
=======================================
  Hits         6182     6182           
  Misses       5507     5507           
  Partials      287      287           
Flag Coverage Δ
backend 51.61% <ø> (ø)
frontend 51.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@naknomum naknomum added this to the 10.10.1 milestone May 5, 2026
@naknomum naknomum merged commit e7ca0d4 into main May 8, 2026
1 check passed
@naknomum naknomum deleted the fix_for_encounter_api_duplicate_assets branch May 8, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants