Skip to content

Warnings and defensive coding #1119

Warnings and defensive coding

Warnings and defensive coding #1119

Triggered via pull request January 18, 2024 00:51
Status Success
Total duration 17m 38s
Artifacts 6

dotnet.yml

on: pull_request
Build and Optionally Publish Meadow.CLI nuget
4m 1s
Build and Optionally Publish Meadow.CLI nuget
Build Win 2022 Extension
13m 12s
Build Win 2022 Extension
Build Mac 2022 Extension
1m 26s
Build Mac 2022 Extension
Build VSCode Extension
6m 30s
Build VSCode Extension
Fit to window
Zoom out
Zoom in

Annotations

71 warnings
Build and Optionally Publish Meadow.CLI nuget
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1, NuGet/[email protected], actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/Firmware/FirmwareInfo.cs#L41
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/Devices/MeadowLocalDevice.cs#L18
Nullability of reference types in return type of 'ILogger? MeadowLocalDevice.Logger.get' doesn't match implicitly implemented member 'ILogger IMeadowDevice.Logger.get' (possibly because of nullability attributes).
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/Devices/MeadowLocalDevice.FileManager.cs#L291
Nullability of reference types in type of parameter 'fileName' of 'Task MeadowLocalDevice.WriteFileToEspFlash(string fileName, uint partition = 0, string? mcuDestAddress = null, CancellationToken cancellationToken = default(CancellationToken))' doesn't match implicitly implemented member 'Task IMeadowDevice.WriteFileToEspFlash(string? fileName, uint partition = 0, string? mcuDestAddress = null, CancellationToken cancellationToken = default(CancellationToken))' (possibly because of nullability attributes).
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/Devices/MeadowLocalDevice.cs#L40
Nullability of reference types in return type of 'Task<MeadowDeviceInfo?> MeadowLocalDevice.GetDeviceInfo(TimeSpan timeout, CancellationToken cancellationToken = default(CancellationToken))' doesn't match implicitly implemented member 'Task<MeadowDeviceInfo> IMeadowDevice.GetDeviceInfo(TimeSpan timeout, CancellationToken cancellationToken = default(CancellationToken))'.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/Settings.cs#L33
Dereference of a possibly null reference.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/ReleaseMetadata.cs#L11
Non-nullable property 'Version' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/ReleaseMetadata.cs#L13
Non-nullable property 'MinCLIVersion' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/ReleaseMetadata.cs#L15
Non-nullable property 'DownloadURL' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/ReleaseMetadata.cs#L17
Non-nullable property 'NetworkDownloadURL' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Source/v2/Meadow.SoftwareManager/FirmwarePackage.cs#L9
Non-nullable property 'Version' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Source/v2/Meadow.SoftwareManager/FirmwarePackage.cs#L9
Non-nullable property 'Targets' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Source/v2/Meadow.SoftwareManager/F7FirmwarePackageCollection.cs#L37
Non-nullable event 'DefaultVersionChanged' must contain a non-null value when exiting constructor. Consider declaring the event as nullable.
Build and Optionally Publish Meadow.CLI nuget: Source/v2/Meadow.SoftwareManager/F7FirmwarePackageCollection.cs#L94
Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call.
Build and Optionally Publish Meadow.CLI nuget: Source/v2/Meadow.SoftwareManager/F7FirmwarePackageCollection.cs#L93
Possible null reference argument for parameter 'item' in 'bool List<FirmwarePackage>.Remove(FirmwarePackage item)'.
Build and Optionally Publish Meadow.CLI nuget: Source/v2/Meadow.Cloud.Client/Messages/PackageInfo.cs#L8
Non-nullable property 'Version' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Source/v2/Meadow.Cloud.Client/Messages/PackageInfo.cs#L10
Non-nullable property 'OsVersion' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Source/v2/Meadow.Cloud.Client/Messages/UserOrg.cs#L8
Non-nullable property 'Id' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Source/v2/Meadow.Cloud.Client/Messages/UserOrg.cs#L10
Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/Firmware/FirmwareInfo.cs#L41
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/Devices/MeadowLocalDevice.cs#L18
Nullability of reference types in return type of 'ILogger? MeadowLocalDevice.Logger.get' doesn't match implicitly implemented member 'ILogger IMeadowDevice.Logger.get' (possibly because of nullability attributes).
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/Devices/MeadowLocalDevice.FileManager.cs#L291
Nullability of reference types in type of parameter 'fileName' of 'Task MeadowLocalDevice.WriteFileToEspFlash(string fileName, uint partition = 0, string? mcuDestAddress = null, CancellationToken cancellationToken = default(CancellationToken))' doesn't match implicitly implemented member 'Task IMeadowDevice.WriteFileToEspFlash(string? fileName, uint partition = 0, string? mcuDestAddress = null, CancellationToken cancellationToken = default(CancellationToken))' (possibly because of nullability attributes).
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/Devices/MeadowLocalDevice.cs#L40
Nullability of reference types in return type of 'Task<MeadowDeviceInfo?> MeadowLocalDevice.GetDeviceInfo(TimeSpan timeout, CancellationToken cancellationToken = default(CancellationToken))' doesn't match implicitly implemented member 'Task<MeadowDeviceInfo> IMeadowDevice.GetDeviceInfo(TimeSpan timeout, CancellationToken cancellationToken = default(CancellationToken))'.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/Settings.cs#L33
Dereference of a possibly null reference.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/ReleaseMetadata.cs#L11
Non-nullable property 'Version' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/ReleaseMetadata.cs#L13
Non-nullable property 'MinCLIVersion' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/ReleaseMetadata.cs#L15
Non-nullable property 'DownloadURL' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget: Meadow.CLI.Core/ReleaseMetadata.cs#L17
Non-nullable property 'NetworkDownloadURL' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build and Optionally Publish Meadow.CLI nuget
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build Mac 2022 Extension
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1, NuGet/[email protected], actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build Mac 2022 Extension: Meadow.CLI.Core/Firmware/FirmwareInfo.cs#L41
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
Build Mac 2022 Extension: Meadow.CLI.Core/Devices/MeadowLocalDevice.cs#L18
Nullability of reference types in return type of 'ILogger? MeadowLocalDevice.Logger.get' doesn't match implicitly implemented member 'ILogger IMeadowDevice.Logger.get' (possibly because of nullability attributes).
Build Mac 2022 Extension: Meadow.CLI.Core/Devices/MeadowLocalDevice.FileManager.cs#L291
Nullability of reference types in type of parameter 'fileName' of 'Task MeadowLocalDevice.WriteFileToEspFlash(string fileName, uint partition = 0, string? mcuDestAddress = null, CancellationToken cancellationToken = default(CancellationToken))' doesn't match implicitly implemented member 'Task IMeadowDevice.WriteFileToEspFlash(string? fileName, uint partition = 0, string? mcuDestAddress = null, CancellationToken cancellationToken = default(CancellationToken))' (possibly because of nullability attributes).
Build Mac 2022 Extension: Meadow.CLI.Core/Devices/MeadowLocalDevice.cs#L40
Nullability of reference types in return type of 'Task<MeadowDeviceInfo?> MeadowLocalDevice.GetDeviceInfo(TimeSpan timeout, CancellationToken cancellationToken = default(CancellationToken))' doesn't match implicitly implemented member 'Task<MeadowDeviceInfo> IMeadowDevice.GetDeviceInfo(TimeSpan timeout, CancellationToken cancellationToken = default(CancellationToken))'.
Build Mac 2022 Extension: Meadow.CLI.Core/Settings.cs#L33
Dereference of a possibly null reference.
Build Mac 2022 Extension: Meadow.CLI.Core/Settings.cs#L46
Possible null reference return.
Build Mac 2022 Extension: Meadow.CLI.Core/ReleaseMetadata.cs#L11
Non-nullable property 'Version' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Mac 2022 Extension: Meadow.CLI.Core/ReleaseMetadata.cs#L13
Non-nullable property 'MinCLIVersion' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Mac 2022 Extension: Meadow.CLI.Core/ReleaseMetadata.cs#L15
Non-nullable property 'DownloadURL' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Mac 2022 Extension: Meadow.CLI.Core/ReleaseMetadata.cs#L17
Non-nullable property 'NetworkDownloadURL' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Mac 2022 Extension
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build VSCode Extension
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1, Nuget/[email protected], actions/setup-node@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build VSCode Extension
The target framework 'net5.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build VSCode Extension
The target framework 'net5.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build VSCode Extension
The target framework 'net5.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build VSCode Extension
The target framework 'net5.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build VSCode Extension
The target framework 'net5.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build VSCode Extension
The target framework 'net5.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.
Build VSCode Extension
ProjectReference 'D:\a\Meadow.CLI\Meadow.CLI\vs-code\externals\nrefactory\ICSharpCode.NRefactory\ICSharpCode.NRefactory.csproj' was resolved using '.NETFramework,Version=v4.7.2' instead of the project target framework '.NETCoreApp,Version=v7.0'. This project may not be fully compatible with your project.
Build VSCode Extension
ProjectReference 'D:\a\Meadow.CLI\Meadow.CLI\vs-code\externals\nrefactory\ICSharpCode.NRefactory.CSharp\ICSharpCode.NRefactory.CSharp.csproj' was resolved using '.NETFramework,Version=v4.7.2' instead of the project target framework '.NETCoreApp,Version=v7.0'. This project may not be fully compatible with your project.
Build VSCode Extension: Meadow.CLI.Core/Firmware/FirmwareInfo.cs#L41
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
Build VSCode Extension: Meadow.CLI.Core/Devices/MeadowLocalDevice.cs#L18
Nullability of reference types in return type of 'ILogger? MeadowLocalDevice.Logger.get' doesn't match implicitly implemented member 'ILogger IMeadowDevice.Logger.get' (possibly because of nullability attributes).
Build VSCode Extension: Meadow.CLI.Core/Devices/MeadowLocalDevice.FileManager.cs#L291
Nullability of reference types in type of parameter 'fileName' of 'Task MeadowLocalDevice.WriteFileToEspFlash(string fileName, uint partition = 0, string? mcuDestAddress = null, CancellationToken cancellationToken = default(CancellationToken))' doesn't match implicitly implemented member 'Task IMeadowDevice.WriteFileToEspFlash(string? fileName, uint partition = 0, string? mcuDestAddress = null, CancellationToken cancellationToken = default(CancellationToken))' (possibly because of nullability attributes).
Build VSCode Extension: Meadow.CLI.Core/Devices/MeadowLocalDevice.cs#L40
Nullability of reference types in return type of 'Task<MeadowDeviceInfo?> MeadowLocalDevice.GetDeviceInfo(TimeSpan timeout, CancellationToken cancellationToken = default(CancellationToken))' doesn't match implicitly implemented member 'Task<MeadowDeviceInfo> IMeadowDevice.GetDeviceInfo(TimeSpan timeout, CancellationToken cancellationToken = default(CancellationToken))'.
Build VSCode Extension: Meadow.CLI.Core/Settings.cs#L33
Dereference of a possibly null reference.
Build VSCode Extension
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build Win 2022 Extension
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1, NuGet/[email protected], actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build Win 2022 Extension: Meadow.CLI.Core/Devices/MeadowLocalDevice.cs#L18
Nullability of reference types in return type of 'ILogger? MeadowLocalDevice.Logger.get' doesn't match implicitly implemented member 'ILogger IMeadowDevice.Logger.get' (possibly because of nullability attributes).
Build Win 2022 Extension: Meadow.CLI.Core/Devices/MeadowLocalDevice.FileManager.cs#L291
Nullability of reference types in type of parameter 'fileName' of 'Task MeadowLocalDevice.WriteFileToEspFlash(string fileName, uint partition = 0, string? mcuDestAddress = null, CancellationToken cancellationToken = default(CancellationToken))' doesn't match implicitly implemented member 'Task IMeadowDevice.WriteFileToEspFlash(string? fileName, uint partition = 0, string? mcuDestAddress = null, CancellationToken cancellationToken = default(CancellationToken))' (possibly because of nullability attributes).
Build Win 2022 Extension: Meadow.CLI.Core/Devices/MeadowLocalDevice.cs#L40
Nullability of reference types in return type of 'Task<MeadowDeviceInfo?> MeadowLocalDevice.GetDeviceInfo(TimeSpan timeout, CancellationToken cancellationToken = default(CancellationToken))' doesn't match implicitly implemented member 'Task<MeadowDeviceInfo> IMeadowDevice.GetDeviceInfo(TimeSpan timeout, CancellationToken cancellationToken = default(CancellationToken))'.
Build Win 2022 Extension: Meadow.CLI.Core/ReleaseMetadata.cs#L11
Non-nullable property 'Version' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Win 2022 Extension: Meadow.CLI.Core/ReleaseMetadata.cs#L13
Non-nullable property 'MinCLIVersion' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Win 2022 Extension: Meadow.CLI.Core/ReleaseMetadata.cs#L15
Non-nullable property 'DownloadURL' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Win 2022 Extension: Meadow.CLI.Core/ReleaseMetadata.cs#L17
Non-nullable property 'NetworkDownloadURL' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Win 2022 Extension: Meadow.CLI.Core/PackageVersions.cs#L8
Non-nullable property 'Versions' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Win 2022 Extension: Meadow.CLI.Core/PackageInfo.cs#L8
Non-nullable property 'Version' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Win 2022 Extension: Meadow.CLI.Core/PackageInfo.cs#L10
Non-nullable property 'OsVersion' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
Build Win 2022 Extension
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Artifacts

Produced during runtime
Name Size
Meadow.CLI.Classic.nuget.1.5.0.0 Expired
3.38 MB
Meadow.CLI.V2.nuget.2.0.0 Expired
3.68 MB
Meadow.CLI.nuget.1.5.0.0 Expired
3.69 MB
Meadow.Mac.2022.mpack.1.5.0 Expired
635 KB
Meadow.VSCode.vsix.1.5.0 Expired
9.31 MB
Meadow.Win.VS2022.vsix.1.5.0 Expired
3.44 MB