Skip to content

Commit

Permalink
make device ID upper case on provisioning
Browse files Browse the repository at this point in the history
  • Loading branch information
ctacke committed May 25, 2024
1 parent 65d96ac commit d261c30
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Meadow.CLI.Commands.DeviceManagement;

[Command("app deploy", Description = "Deploy a compiled Meadow application to a target device")]
[Command("app deploy", Description = "Deploys a previously compiled Meadow application to a target device. Note: This command does not compile the application.")]
public class AppDeployCommand : BaseDeviceCommand<AppDeployCommand>
{
private readonly IPackageManager _packageManager;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ protected override async ValueTask ExecuteCommand()
{
throw new CommandException("If a public key is provided, an `id` must also be provided");
}
provisioningID = SerialNumber.ToUpper();
provisioningID = SerialNumber;
provisioningName = Name ?? string.Empty;
}
else
Expand Down Expand Up @@ -176,7 +176,9 @@ protected override async ValueTask ExecuteCommand()

Logger?.LogInformation(Strings.ProvisioningWithCloud);

var result = await _deviceService.AddDevice(org.Id!, provisioningID!, PublicKey, CollectionId, provisioningName, Host, CancellationToken);
provisioningID = provisioningID!.ToUpper();

var result = await _deviceService.AddDevice(org.Id!, provisioningID, PublicKey, CollectionId, provisioningName, Host, CancellationToken);

if (result.isSuccess)
{
Expand Down

0 comments on commit d261c30

Please sign in to comment.