tighten up coprocessor write

WildernessLabs · Sep 29, 2023 · d5f0605 · d5f0605
1 parent 7af0825
commit d5f0605
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 19 deletions.
diff --git a/Source/v2/Meadow.Hcom/Connections/SerialConnection.ListenerProc.cs b/Source/v2/Meadow.Hcom/Connections/SerialConnection.ListenerProc.cs
@@ -223,7 +223,7 @@ private async Task ListenerProc()
                                         // When the F7 has finished sending the data it will send a
                                         // HCOM_HOST_REQUEST_UPLOAD_FILE_COMPLETED message. When it is received
                                         // we then close the open file and the process is completed.
-                                        var folder = Path.GetDirectoryName(_readFileInfo.LocalFileName);
+                                        var folder = Path.GetDirectoryName(_readFileInfo!.LocalFileName);
                                         if (!Directory.Exists(folder)) throw new DirectoryNotFoundException(folder);
 
                                         _readFileInfo.FileStream = File.Create(_readFileInfo.LocalFileName);
@@ -276,7 +276,7 @@ private async Task ListenerProc()
                                     }
                                     else
                                     {
-                                        Debug.WriteLine($"{response.GetType().Name} for:{response.RequestType}");
+                                        Debug.WriteLine($"{response?.GetType().Name} for:{response?.RequestType}");
                                         // try to match responses with the requests
                                     }
                                 }

diff --git a/Source/v2/Meadow.Hcom/Connections/SerialConnection.cs b/Source/v2/Meadow.Hcom/Connections/SerialConnection.cs
@@ -890,32 +890,21 @@ public override async Task<bool> WriteCoprocessorFile(
 
         try
         {
+            RaiseConnectionMessage("\nTransferring file to coprocessor...");
+
             // push the file to the device
             await WriteFile(localFileName, null,
                 RequestType.HCOM_MDOW_REQUEST_START_ESP_FILE_TRANSFER,
                 RequestType.HCOM_MDOW_REQUEST_END_ESP_FILE_TRANSFER,
                 destinationAddress,
                 cancellationToken);
 
-            RaiseConnectionMessage("\nTransferring file to coprocessor...");
-
-            // now wait for the STM32 to finish writing to the ESP32
-            return await WaitForResult(() =>
-            {
-                if (InfoMessages.Count != infoCount)
-                {
-                    infoCount = InfoMessages.Count;
-                    RaiseConnectionMessage(InfoMessages.Last());
-                }
 
-                if (_lastRequestConcluded != null)
-                {
-                    return true;
-                }
+            _lastRequestConcluded = null;
 
-                return false;
-            },
-            cancellationToken);
+            // now wait for the STM32 to finish writing to the ESP32
+            await WaitForConcluded(null, cancellationToken);
+            return true;
         }
         finally
         {