Reduce compilation warnings, so we can see when something is wrong. #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CartBlanche
requested review from
lamebrain,
jorgedevs,
ctacke and
adrianstevens
CartBlanche
changed the title
|
@CartBlanche are you still working on this? If you're not, mark as Ready for Review and we can take a look. |
|
@jorgedevs Yes I'm still working on it (2 other PRs have take priority over the last week). Also more testing required as it's quite an extensive change. Hopefully this week I'll change it to ready for review. |
CartBlanche
force-pushed
the
dominique-ZeroWarnings
branch
from
e433e39 to
132df6c
Compare
CartBlanche
force-pushed
the
dominique-ZeroWarnings
branch
from
9d66f16 to
3b17ce0
Compare
|
@jorgedevs I've decided to park this PR and instead work on zeroing the warnings in V2. |
ctacke
reviewed
Oct 4, 2023
| public string FirstName { get; set; } | ||
| public string LastName { get; set; } | ||
| public string FullName { get; set; } | ||
| public string? Id { get; set; } |
There was a problem hiding this comment.
Since these are DTOs used by Cloud, verify that these can be nullable objects and still operate before committing these. the other option is to initialize them to default!, which will also eliminate the warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.