Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format device info output, to what we have now. #358

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Format device info output, to what we have now. #358

merged 1 commit into from
Sep 28, 2023

Conversation

CartBlanche
Copy link
Collaborator

@CartBlanche CartBlanche commented Sep 28, 2023 •
edited
Loading

Output for device info now looks like:

Getting device info...
Meadow by Wilderness Labs
Board Information
    Model: F7Micro
    Hardware version: F7CoreComputeV2
    Device name: MeadowF7

Hardware Information
    Processor type: STM32F777IIK6
    ID: 37-00-24-00-07-51-38-34-35-31-38-33
    Serial number: 335C31763438
    Coprocessor type: ESP32
    MAC Address -
        WiFi: 4C:75:25:D7:15:98

Firmware Versions
    OS: 1.3.4.0
    Mono: 1.3.4.0
    Coprocessor: 1.3.4.0
    Protocol: 7

Done.

@CartBlanche CartBlanche requested a review from ctacke September 28, 2023 11:11
@CartBlanche CartBlanche self-assigned this Sep 28, 2023
@CartBlanche CartBlanche changed the title Format device info out, to what we have now. Format device info output, to what we have now. Sep 28, 2023
@CartBlanche
Copy link
Collaborator Author

@ctacke AFAICT we don't support previous protocol versions in V2. So right now I'm doing this:
https://github.com/WildernessLabs/Meadow.CLI/pull/358/files#diff-f79cbc109b03e654e71c1fb3ad3719708f06103951cfa869c3c6cc67982efb0dR88
Is that something we will add?

@ctacke
Copy link
Contributor

ctacke commented Sep 28, 2023

I'm fine with not supporting previous versions. This will require some rework because those fields don't necessarily exist in Linux but I can worry about that later.

@CartBlanche CartBlanche merged commit 4badc53 into develop Sep 28, 2023
6 checks passed
@CartBlanche CartBlanche deleted the dominique-V2FormatDeviceInfo branch September 28, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctacke ctacke ctacke approved these changes

Assignees

@CartBlanche CartBlanche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CartBlanche @ctacke