Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runtime commands on macOS #381

Merged
merged 5 commits into from
Oct 21, 2023
Merged

Fix runtime commands on macOS #381

merged 5 commits into from
Oct 21, 2023

Conversation

CartBlanche
Copy link
Collaborator

@CartBlanche CartBlanche commented Oct 20, 2023 •
edited
Loading

Even though this PR was to only fix the runtime command on macOS, in the end I found other issue that needed addressing. Fixes are:

  • Runtime commands now no longer timeout, as we listen out for the correct response message.
  • - Add --verbose option for logging.
  • - Some refactoring to add more exception handling and belt and braces defensive coding.
  • - Fix a duplicate messages bug introduced in the previous big PR via DeviceMessageReceived.

@CartBlanche CartBlanche self-assigned this Oct 20, 2023
@CartBlanche CartBlanche marked this pull request as ready for review October 21, 2023 11:41
@ctacke ctacke merged commit 5a757ea into develop Oct 21, 2023
6 checks passed
@CartBlanche CartBlanche deleted the dominique-FixRuntimeCommandsOnMac branch October 22, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctacke ctacke ctacke approved these changes

@adrianstevens adrianstevens Awaiting requested review from adrianstevens

Assignees

@CartBlanche CartBlanche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CartBlanche @ctacke