Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more *.IsCancellationRequested checks, so we can bail sooner in l… #405

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Add more *.IsCancellationRequested checks, so we can bail sooner in l… #405

merged 8 commits into from
Dec 11, 2023

Conversation

CartBlanche
Copy link
Collaborator

@CartBlanche CartBlanche commented Nov 26, 2023 •
edited
Loading

…oops.

Fixes #404
Fixes #406

@CartBlanche CartBlanche self-assigned this Nov 26, 2023
@CartBlanche CartBlanche deleted the branch develop December 4, 2023 18:59
@CartBlanche CartBlanche closed this Dec 4, 2023
@CartBlanche CartBlanche reopened this Dec 4, 2023
NevynUK
NevynUK approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@NevynUK NevynUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 11 Dec 23.

@CartBlanche CartBlanche merged commit edd0f91 into develop Dec 11, 2023
@CartBlanche CartBlanche deleted the dominique-Fix404 branch December 11, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NevynUK NevynUK NevynUK approved these changes

@ctacke ctacke Awaiting requested review from ctacke

@adrianstevens adrianstevens Awaiting requested review from adrianstevens

Assignees

@CartBlanche CartBlanche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cosmetic issue when deploying an application (V2) App Deploy fails - V2 Alpha 4
2 participants
@CartBlanche @NevynUK