Skip to content

Refresh firmware store before reading on trim and package #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctacke merged 1 commit into from
Jun 4, 2024
Merged

Refresh firmware store before reading on trim and package #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/v2/Meadow.Cli/Commands/Current/App/AppTrimCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ public AppTrimCommand(FileManager fileManager, IPackageManager packageManager, M

protected override async ValueTask ExecuteCommand()
{
await _fileManager.Refresh();

// for now we only support F7
// TODO: add switch and support for other platforms
var collection = _fileManager.Firmware["Meadow F7"];
Expand All @@ -39,8 +41,6 @@ protected override async ValueTask ExecuteCommand()
throw new CommandException(Strings.NoFirmwarePackagesFound, CommandExitCode.GeneralError);
}

await _fileManager.Refresh();

var path = AppTools.ValidateAndSanitizeAppPath(Path);

if (!File.Exists(path))
Expand Down
1 change: 1 addition & 0 deletions Source/v2/Meadow.Cli/Commands/Current/Cloud/Package/CloudPackageCreateCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public CloudPackageCreateCommand(

protected override async ValueTask ExecuteCommand()
{
await _fileManager.Refresh();
var store = _fileManager.Firmware["Meadow F7"];
await ValidateFirmwarePackage(store);

Expand Down
2 changes: 1 addition & 1 deletion Source/v2/Meadow.Cli/Meadow.CLI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<Authors>Wilderness Labs, Inc</Authors>
<Company>Wilderness Labs, Inc</Company>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<PackageVersion>2.0.45.0</PackageVersion>
<PackageVersion>2.0.47.0</PackageVersion>
<Platforms>AnyCPU</Platforms>
<PackageProjectUrl>http://developer.wildernesslabs.co/Meadow/Meadow.CLI/</PackageProjectUrl>
<RepositoryUrl>https://github.com/WildernessLabs/Meadow.CLI</RepositoryUrl>
Expand Down
2 changes: 1 addition & 1 deletion Source/v2/Meadow.Cli/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ namespace Meadow.CLI;

public static class Constants
{
public const string CLI_VERSION = "2.0.45.0";
public const string CLI_VERSION = "2.0.47.0";
}