-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meadow update command. #576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make any sense to wrap another CLI call in our CLI
I've always thought that the idea of wrapping this particular CLI call (or other complex CLI calls) is to minimise the paper cuts our customers encounter when using the Meadow stack, by having to remember the long MS command as well as the correct parameters required. Also the We already simplify the lives of our customers with our own CLI wrapper of the It seems easier for customers to remember
We could also allow them to roll back to specific versions, should something break or become unstable in vLatest. Obviously not too far back as then |
1aecaf3
to
f2dd343
Compare
f2dd343
to
5bbcff1
Compare
5bbcff1
to
ad9fa9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the updater and stand-alone app. I don't think it needs to be called from the Meadow.CLI console app since it's already it's own app.
@adrianstevens just to be clear the Meadow.CLI needs to shell out then shutdown for the updater app to actually then perform the update. So are you suggesting that the updater app be in it's own repo or something else?? |
@@ -88,7 +88,7 @@ jobs: | |||
run: dotnet build main/MeadowCLI.Classic.sln /p:Configuration=Release | |||
|
|||
- name: Upload nuget Artifacts for internal testing | |||
uses: actions/upload-artifact@v2 | |||
uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates to the build actions should not be in with code changes. If this had been a stand-along PR, it would have already been merged.
I'm also in the camp of "this is not a good idea". If we're simply trying to make it easier a user who forgets the command, why not just echo out the proper command for them? Creating a new command that creates a new process and calls some other existing CLI seems clunky AF |
This was my fault. Users kept running into issues with the update and i asked for this feature but didn't realize what a cluster it would be. |
Command to reduce customer paper cuts when needing to update Meadow.CLI.
It is easier for customers to remember
meadow update
, which will update to the latest version, rather than remembering:We could also allow them to roll back to specific versions, should something break or become unstable in vLatest. Obviously not too far back as then
meadow update
wouldn't be available.Tested on:
When run on Mac and Linux this is the output: