Switch to tree-sitter-rust-orchard, fixing attribute attachment in Rust #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wetneb
force-pushed
the
update_rust_parser
branch
from
01ab83c to
1a07299
Compare
wetneb
force-pushed
the
update_rust_parser
branch
from
1a07299 to
49f2c62
Compare
Offers better attachment of attributes and doc comments and supports newer language constructs. Closes Wilfred#35.
wetneb
force-pushed
the
update_rust_parser
branch
from
49f2c62 to
ae9da58
Compare
|
Thanks! This largely looks good. I noticed that block_outer_doc_comment isn't handled as a comment in this PR, but you've just fixed it: https://codeberg.org/grammar-orchard/tree-sitter-rust-orchard/commit/d52d4268f15b9c715cd52010cc909f92511610d3 :) I did also notice that there's an unnecessary token, so I've filed https://codeberg.org/grammar-orchard/tree-sitter-rust-orchard/issues/70. I think it's harmless for difftastic, which flattens AST subtrees which are comments anyway. |
|
I see the tests are all passing with 0.13, so merging. Thanks for the PR! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes to update the Rust grammar, to benefit from the following improvements:
See the changelog for details about those improvements.
Those are improvements I made for mergiraf but I figured they might also be useful for difftastic, and indeed I found that this change indeed fixes #35.
Unfortunately the tree-sitter-rust maintainers rarely have capacity to review external contributions, hence it being a fork called
tree-sitter-rust-orchard, which is available on crates.io. The lack of capacity to review seems to be a recurrent problem according to the PR backlog, not just a passing one, but should it change, I would of course submit my changes upstream to have them integrated there too. In the meantime, the fork welcomes contributions and co-maintainers.