Fixed volume buttons, mute, and brightness #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also make sure to add |
|
Thanks! Ill be taking a closer look at this when I have time this weekend |
|
Hello, have you took a look at the pull request yet? Thanks. |
| awesome.emit_signal("volume_change") | ||
| end, | ||
| {description = "volume down", group = "hotkeys"} | ||
| ), | ||
| awful.key({}, "XF86AudioMute", | ||
| function() | ||
| awful.spawn("amixer -D pulse set Master 1+ toggle", false) | ||
| os.execute("/home/$USER/.config/awesome/components/toggle_mute.sh") |
There was a problem hiding this comment.
Can we instead call awful.spawn to run each command in the toggle_mute script?
There was a problem hiding this comment.
I don't think that should cause any problems, so it's probably good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work for newer versions of alsa/Linux kernel.