Skip to content

fix(ranking): refine responsive toolbar layout - #384

Merged
Willxup merged 3 commits into
mainfrom
worktree/ranking-toolbar-mobile-layout
Jul 30, 2026
Merged

fix(ranking): refine responsive toolbar layout#384
Willxup merged 3 commits into
mainfrom
worktree/ranking-toolbar-mobile-layout

Conversation

@Willxup

@Willxup Willxup commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep the ranking metric trigger compact while retaining full metric names in the dropdown
  • place period tabs and the metric selector in a responsive horizontal toolbar
  • align the participation action across intermediate and mobile layouts
  • preserve visible keyboard focus and logical focus order

Validation

  • frontend verification: 103 test files and 959 tests passed
  • ESLint, TypeScript typecheck, and production build passed
  • backend-served page, health, and session endpoints returned HTTP 200

Keep ranking filters compact across desktop and narrow cards while preserving full metric names in the dropdown. Align responsive profile actions with keyboard order and retain visible focus treatment inside the scrollable toolbar.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2015d7670d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread web/src/features/ranking/RankingPage.tsx Outdated
Willxup added 2 commits July 30, 2026 14:36
Keep the visible ranking profile identity in the button accessible name while retaining the localized action label for mobile layouts.
# Conflicts:
#	web/src/features/ranking/RankingPage.module.scss
@Willxup
Willxup merged commit 18efa6b into main Jul 30, 2026
4 checks passed
@Willxup
Willxup deleted the worktree/ranking-toolbar-mobile-layout branch July 30, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant