additionalProperties without schema should allow null.

Issue python-openapi#442
Wim-De-Clercq · Dec 12, 2022 · ae27109 · ae27109
1 parent 4055a36
commit ae27109
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/openapi_core/unmarshalling/schemas/unmarshallers.py b/openapi_core/unmarshalling/schemas/unmarshallers.py
@@ -292,7 +292,7 @@ def _unmarshal_properties(self, value: Any) -> Any:
         if additional_properties is not False:
             # free-form object
             if additional_properties is True:
-                additional_prop_schema = Spec.from_dict({})
+                additional_prop_schema = Spec.from_dict({"nullable": True})
             # defined schema
             else:
                 additional_prop_schema = self.schema / "additionalProperties"

diff --git a/tests/integration/validation/test_petstore.py b/tests/integration/validation/test_petstore.py
@@ -752,6 +752,7 @@ def test_post_cats(self, spec, spec_dict):
             "ears": {
                 "healthy": pet_healthy,
             },
+            "extra": 1,
         }
         data = json.dumps(data_json)
         headers = {
@@ -799,6 +800,7 @@ def test_post_cats(self, spec, spec_dict):
         assert result.body.address.street == pet_street
         assert result.body.address.city == pet_city
         assert result.body.healthy == pet_healthy
+        assert result.body.extra is None
 
     def test_post_cats_boolean_string(self, spec, spec_dict):
         host_url = "https://staging.gigantic-server.com/v1"