Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/infomation-panel-close-button #1375

Merged
merged 2 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/lovely-cars-explode.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@wizleap-inc/wiz-ui-react": minor
"@wizleap-inc/wiz-ui-next": minor
"@wizleap-inc/wiz-ui-styles": minor
---

Chore(infomation-panel): update close button position
4 changes: 0 additions & 4 deletions packages/styles/bases/information-panel.css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,3 @@ export const informationPanelFontStyle = styleVariants({
color: THEME.color.red["800"],
},
});

export const informationPanelIconStyle = style({
margin: "auto 0",
});
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,24 @@
</template>
</div>
</WizVStack>
<div :class="[informationPanelIconStyle]">
<WizVStack align="center">
<WizIconButton
variant="transparent"
:icon="WizIClose"
@click="close"
:ariaLabel="ARIA_LABELS.INFORMATION_PANEL.CLOSE"
/>
</WizVStack>
</div>
<WizVStack>
<WizIconButton
variant="transparent"
:icon="WizIClose"
@click="close"
:ariaLabel="ARIA_LABELS.INFORMATION_PANEL.CLOSE"
/>
</WizVStack>
</div>
</template>
<script setup lang="ts">
import { ARIA_LABELS, ComponentName } from "@wizleap-inc/wiz-ui-constants";
import {
informationPanelBorderStyle,
informationPanelFontStyle,
informationPanelIconStyle,
informationPanelStyle,
} from "@wizleap-inc/wiz-ui-styles/bases/information-panel.css";
import { PropType, computed, Component as ComponentType } from "vue"; // Componentの場合、<component>タグと競合するためエイリアスをつける
import { Component as ComponentType, PropType, computed } from "vue"; // Componentの場合、<component>タグと競合するためエイリアスをつける
import { WizIClose, WizIconButton } from "@/components";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,13 @@ const InformationPanel: FC<Props> = ({
)
)}
</WizVStack>
<div className={styles.informationPanelIconStyle}>
<WizVStack align="center">
<WizIconButton
variant="transparent"
icon={WizIClose}
onClick={onClose}
/>
</WizVStack>
</div>
<WizVStack align="start">
<WizIconButton
variant="transparent"
icon={WizIClose}
onClick={onClose}
/>
</WizVStack>
</div>
);
};
Expand Down
Loading