Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for block changes in 5.3 #56

Merged
merged 3 commits into from
Jan 30, 2020
Merged

Conversation

joyously
Copy link
Contributor

Some block syntax changed and some inline styles changed to class names.
Added missing core blocks.
For #55

Some block syntax changed and some inline styles changed to class names.
Added missing core blocks.
Original data was from a multisite with year folders. The changes for 5.3 were made on a singular site with no year folders.
This edit makes the path names consistent for the original data.
A few minor changes also, as I saw them.
@carolinan
Copy link

I like the text changes a lot, and the block additions.
But I am getting 404 messages for most of the images in the block gallery.
Not for the classic gallery.

Change some dates on images to reduce confusion.
Remove one duplicate image.
Fix references to images using wrong date folders.
@joyously
Copy link
Contributor Author

I updated it with the original image paths (which are of course the old date). Funny that just this morning, we were discussing in Slack #forums a forum question about which date is used on image uploads. New images for an old post use the post publish date. It seems that imports use the post publish date also, so I changed those to match the original, just so everything would match. It seems that the importer doesn't deal with all URLs in blocks. The data-link is ignored.
See WordPress/wordpress-importer#63
So after import, there are still references to the original site (links and File block).

@carolinan carolinan merged commit 014d28d into WordPress:master Jan 30, 2020
@joyously joyously deleted the patch-3 branch January 30, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants