Consider draft tickets sold for the purposes of ticketing. #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partially related to #1296 - that only tickets in the published+pending state are considered sold, resulting in payment gateways that leave the ticket as draft during the checkout (Which I think includes Stripe?), allowing for overselling of tickets.
If a ticket didn't complete the transaction, it would stay as draft for 24hrs and then move to
timeout, and the ticket would become available again.Edit: 'pending' is a payment thats completed, but is "pending completion" ie. a Bank transfer via Paypal. This status isn't used by stripe. It doesn't make sense that a payment would be pending during the transaction redirect.
See #1301
Props ,
Screenshots
How to test the changes in this Pull Request: