-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error message under input field. #8273
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also some misc. code style issues in the JS, mostly surrounding use of spaces - in general the content inside parentheses should have spaces, e.g. $( '#submit-customlinkdiv' )
.
But this is generally good; just needs some minor polish.
@@ -1103,12 +1103,38 @@ | |||
|
|||
$('#add-custom-links input[type="text"]').on( 'keypress', function(e){ | |||
$('#customlinkdiv').removeClass('form-invalid'); | |||
$('#custom-menu-item-url').hide(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be #custom-url-error
.
.attr('aria-describedby', 'custom-url-error'); | ||
|
||
var errorText = wp.i18n.__('No content entered. Please enter a valid link.'); | ||
errorMessage.show(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I suggested this text, but given the flexibility in what the possible values can be, probably need to make this more general yet. Perhaps "Content is required for the link's href
attribute."
Trac ticket: https://core.trac.wordpress.org/ticket/60969
Add error message to URL input field under the add custom link section.
Add CSS to the error message.