-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block support: Add server-side processing for ariaLabel #8274
Conversation
$attributes_to_merge = array( 'style', 'class', 'id' ); | ||
$attributes_to_merge = array( 'style', 'class', 'id', 'aria-label' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR also allows the aria-label
attribute by default in the get_block_wrapper_attributes
function, otherwise blocks that have this support would need to explicitly specify the additional attribute, like so:
$wrapper_attributes = get_block_wrapper_attributes( array( 'aria-label' => $attributes['ariaLabel'] ) );
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code here looks good to me 👍
It matches how other similar block supports handle their server side processing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor formatting suggestions. Otherwise, looks ok.
Co-authored-by: Joe McGill <[email protected]>
Co-authored-by: Joe McGill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the feedback is addressed, and it looks good to commit.
Testing Instructions
See Gutenberg PR for reference.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.