Remove check that prevented resizing of large PNG images

[adamsilverstein]

This check is no longer required. The larger output files issue was resolved separately in https://core.trac.wordpress.org/ticket/36477, fixed in https://core.trac.wordpress.org/changeset/59589.

Trac ticket: https://core.trac.wordpress.org/ticket/62900

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[adamsilverstein]

All image sizes remain smaller than the original large uploaded PNG, including the full sized and large size.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props adamsilverstein, mukesh27, flixos90, azaozz.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[mukeshpanchal27]

Nit-pick

[adamsilverstein]

Worth reviewing without whitespace changes visible: https://github.com/WordPress/wordpress-develop/pull/8275/files?diff=unified&w=1

[felixarntz]

@adamsilverstein I think the PR looks good if that's the direction we want to take. But I think we should gather more feedback on this before proceeding.

I am not opposed by any means, but I would like us to get people that were involved in the original change from https://core.trac.wordpress.org/ticket/48736 to weigh in on whether we're now in a good place to remove the exclusion.

cc @azaozz @SergeyBiryukov

[adamsilverstein]

I am not opposed by any means, but I would like us to get people that were involved in the original change from https://core.trac.wordpress.org/ticket/48736 to weigh in on whether we're now in a good place to remove the exclusion.

Sounds good; hopefully we can get this in before beta. I can add some unit tests here to validate the behavior,

[adamsilverstein]

I can add some unit tests here to validate the behavior

I looked into this. I did not find a sample image on any of the previous tickets. For my own manual testing, I created a very large PNG that weighs in at over 6MB., I'm not sure this change warrants adding that much to the repo weight.

test image

new-test-large.png.zip

[azaozz]

The larger output (PNG) files issue was resolved separately in https://core.trac.wordpress.org/ticket/36477, fixed in https://core.trac.wordpress.org/changeset/59589.

Yep, seems fixed. As far as I remember the original report was of a PNG with large dimensions but quite small file size. Tried to find one like that but couldn't, all PNGs that I tested seem to create smaller sub-sizes.

[adamsilverstein]

The larger output (PNG) files issue was resolved separately in https://core.trac.wordpress.org/ticket/36477, fixed in https://core.trac.wordpress.org/changeset/59589.

Yep, seems fixed. As far as I remember the original report was of a PNG with large dimensions but quite small file size. Tried to find one like that but couldn't, all PNGs that I tested seem to create smaller sub-sizes.

Thanks for reviewing / testing.