Fix WordPress Embedded Block Shows Large Whitespace for Short Posts #8286
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix embed block height calculation by setting minimum height for iframe as 100px.
Issue: On frontend if we have WordPress Embedded block with a post that has less content WordPress Embedded block has large whitespace at the bottom.
Solution: Sets minimum height of iframe as 100px.
The embedded iframe height was around 139px, and on mobile (320px width) it was about 161px for short post.
Since, it was less than 200px the iframe was using 200px as height and hence the whitespace.
A minimum height of 100px seems reasonable.
Trac ticket: https://core.trac.wordpress.org/ticket/62934
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.