Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WordPress Embedded Block Shows Large Whitespace for Short Posts #8286

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

devansh016
Copy link

@devansh016 devansh016 commented Feb 10, 2025

Fix embed block height calculation by setting minimum height for iframe as 100px.

Issue: On frontend if we have WordPress Embedded block with a post that has less content WordPress Embedded block has large whitespace at the bottom.

Solution: Sets minimum height of iframe as 100px.
The embedded iframe height was around 139px, and on mobile (320px width) it was about 161px for short post.
Since, it was less than 200px the iframe was using 200px as height and hence the whitespace.

A minimum height of 100px seems reasonable.

Trac ticket: https://core.trac.wordpress.org/ticket/62934


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props devansh2002.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@devansh016
Copy link
Author

Before After
Screenshot 2025-02-10 at 5 50 57 PM Screenshot 2025-02-10 at 5 52 21 PM

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant