Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: Fix parent theme incorrectly not getting resolved #8466

Closed

Conversation

joemcgill
Copy link
Member

@joemcgill joemcgill commented Mar 5, 2025

The initial commit reverts https://core.trac.wordpress.org/changeset/59885 (83b9080), to show that this is indeed the source of the regression. The cause seems to be that wp_is_block_theme() is getting called before the themes are fully set up. Ensuring the post type support for setting the editor default-mode for pages only fires after themes are fully set up fixes this issue.

Trac ticket: https://core.trac.wordpress.org/ticket/63062


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Mar 5, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joemcgill joemcgill requested a review from peterwilsoncc March 5, 2025 21:43
@joemcgill joemcgill requested a review from fabiankaegy March 5, 2025 21:49
@joemcgill joemcgill changed the title Revert "Editor: Set new default rendering mode for Pages." Themes: Fix parent theme incorrectly not getting resolved Mar 5, 2025
@joemcgill joemcgill marked this pull request as ready for review March 7, 2025 03:33
Copy link

github-actions bot commented Mar 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joemcgill, jorbin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member Author

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few updates here.

As an aside: given the way themes get loaded in our PHPUnit suite, I'm not sure it's possible to reproduce this bug in a unit test because the tests run too late. Will keep thinking about it, but given the severity of this bug I think getting a fix in quickly is more important than ensuring we have good test coverage in this case.

@joemcgill joemcgill requested a review from aaronjorbin March 8, 2025 20:02
@joemcgill
Copy link
Member Author

I've updated the logic here to move setting post type support to a standalone callback, as suggested in this comment. @peterwilsoncc any chance you can take another look at this before beta 2?

@joemcgill
Copy link
Member Author

@joemcgill joemcgill closed this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants