-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themes: Fix parent theme incorrectly not getting resolved #8466
Themes: Fix parent theme incorrectly not getting resolved #8466
Conversation
This reverts commit 83b9080.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few updates here.
As an aside: given the way themes get loaded in our PHPUnit suite, I'm not sure it's possible to reproduce this bug in a unit test because the tests run too late. Will keep thinking about it, but given the severity of this bug I think getting a fix in quickly is more important than ensuring we have good test coverage in this case.
I've updated the logic here to move setting post type support to a standalone callback, as suggested in this comment. @peterwilsoncc any chance you can take another look at this before beta 2? |
The initial commit reverts https://core.trac.wordpress.org/changeset/59885 (83b9080), to show that this is indeed the source of the regression. The cause seems to be that
wp_is_block_theme()
is getting called before the themes are fully set up. Ensuring the post type support for setting the editor default-mode for pages only fires after themes are fully set up fixes this issue.Trac ticket: https://core.trac.wordpress.org/ticket/63062
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.